Add new tier-3 target: armv7-unknown-linux-uclibceabihf #88952

skrap · 2021-09-15T01:18:14Z

This change adds a new tier-3 target: armv7-unknown-linux-uclibceabihf

This target is primarily used in embedded linux devices where system resources are slim and glibc is deemed too heavyweight. Cross compilation C toolchains are available here or via buildroot.

The change is based largely on a previous PR #79380 with a few minor modifications. The author of that PR was unable to push the PR forward, and graciously allowed me to take it over.

Per the target tier 3 policy, I volunteer to be the "target maintainer".

This is my first PR to Rust itself, so I apologize if I've missed things!

rust-highfive · 2021-09-15T01:18:16Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

Please see the contribution instructions for more information.

rust-highfive · 2021-09-15T01:18:17Z

⚠️ Warning ⚠️

These commits modify compiler targets. (See the Target Tier Policy.)

oli-obk

Some nits and rustfmt is unhappy, other than than 👍 from me

compiler/rustc_target/src/spec/armv7_unknown_linux_uclibceabihf.rs

library/std/src/sys/unix/args.rs

compiler/rustc_target/src/spec/armv7_unknown_linux_uclibceabihf.rs

skrap · 2021-09-15T13:02:47Z

HI All - Thanks for the feedback. I actually wasn't intending this to be reviewed just yet, as I'd left it in "draft" status, but I will certainly address the feedback. Sorry for engaging you all too soon! TIL: rust-highfive will add S-waiting-on-review to draft PRs!

Would it be appropriate to file a issue against rust-highfive?

Mark-Simulacrum · 2021-09-15T13:10:19Z

We don't generally use draft status to indicate review state, so I don't think a PR/issue is warranted. Different authors have different preferences for early review :)

You can adjust the waiting-on-{review,author} labels with rustbot -- for example:

@rustbot author

(See shortcuts and more freeform labeling docs).

rustbot · 2021-09-15T13:10:20Z

@skrap

skrap · 2021-09-17T21:22:28Z

@rustbot ready

oli-obk · 2021-09-18T07:44:56Z

r? @Mark-Simulacrum

bors · 2021-09-20T00:45:02Z

☔ The latest upstream changes (presumably #88575) made this pull request unmergeable. Please resolve the merge conflicts.

uclibc: fix semver files, add misc symbols This commit gets uclibc support working again, and fixes the semver lists to segregate gnu- and musl- specific symbols to those libc variants. There is a [separate PR](rust-lang/rust#88952) against rust itself to add armv7-unknown-linux-uclibceabihf as a tier 3 platform, and this commit is in support of that effort. Until that's done, we should not use the CI for that platform, but I'm including the CI file here in anticipation of turning it on in the not-too-distant future.

Mark-Simulacrum · 2021-09-23T02:48:12Z

Most of the modified code is outside my domain, so I will r? rust-lang/compiler-team

skrap · 2021-09-23T14:03:39Z

@Mark-Simulacrum Here's what I've come up with for conformance to the tier 3 requirements. Please LMK if you see any issues!

A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)

I volunteer to be the target maintainer. Happy to have help as well (anyone reading this, feel free to reach out!)

Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.
Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it.

The name is patterned after the current tier-2 target armv7-unknown-linux-gnueabihf. It targets the same architecture, and the only difference is that it uses the uclibc standard library rather than the gnu standard library. The "eabi" text designates the ABI (the ARM EABI ) and the "hf" designates the "hard float" floating point passing style, where floating point values are passed in registers rather than on the stack.

There are additional tier-3 uclibc targets which adopt similar naming conventions: armv5te-unknown-linux-uclibceabi, mipsel-unknown-linux-uclibc, mips-unknown-linux-uclibc.

Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users.
The target must not introduce license incompatibilities.

This target does not seem to include any further licensing burden on Rust. The primary components of the toolchain are:

component	version
binutils	2.34
gcc	10.2.0
linux-headers	5.4.61
uclibc	1.0.34

uclibc (https://uclibc-ng.org/) is licensed as LGPL. All of the other toolchain components are presumably already used in any Rust on Linux build.

Anything added to the Rust repository must be under the standard Rust license (MIT OR Apache-2.0).

The code in this PR is offered under the standard Rust license.

The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the tidy tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to be subject to any new license requirements.

This PR conforms to this requirement. I don't expect any change in requirements for any other target.

If the target supports building host tools (such as rustc or cargo), those host tools must not depend on proprietary (non-FOSS) libraries, other than ordinary runtime libraries supplied by the platform and commonly used by other binaries built for the target. For instance, rustc built for the target may depend on a common proprietary C runtime library or console output library, but must not depend on a proprietary code generation library or code optimization library. Rust's license permits such combinations, but the Rust project has no interest in maintaining such combinations within the scope of Rust itself, even at tier 3.

This PR doesn't reference or depend on any non-FOSS code.

Targets should not require proprietary (non-FOSS) components to link a functional binary or library.

It doesn't! 👍

"onerous" here is an intentionally subjective term. At a minimum, "onerous" legal/licensing terms include but are not limited to: non-disclosure requirements, non-compete requirements, contributor license agreements (CLAs) or equivalent, "non-commercial"/"research-only"/etc terms, requirements conditional on the employer or employment of any particular Rust developers, revocable terms, any requirements that create liability for the Rust project or its developers or users, or any requirements that adversely affect the livelihood or prospects of the Rust project or its developers or users.

Acknowledged. I don't expect the requirements here will be considered onerous, as they should not differ from any standard Rust build on Linux.

Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.

👍 I believe this requirement is satisfied.

This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements.

👍 I believe this requirement is satisfied.

Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.

This target (once some PRs are accepted elsewhere, e.g. libc) will build the full Rust x.py dist distribution, including the full Rust standard library. (I'm already doing this in my dev builds.)

The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running tests (even if they do not pass), the documentation must explain how to run tests for the target, using emulation if possible or dedicated hardware if necessary.

Done, see diff. (It would be possible to expand the x.py test emulation targets to include this target, but given that this is only tier 3 it seemed premature.)

Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via @) to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.
Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications.

👍 Acknowledged.

Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.
In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target.

👍 Acknowledged.

compiler/rustc_codegen_llvm/src/callee.rs

compiler/rustc_target/src/spec/armv7_unknown_linux_uclibceabihf.rs

library/std/src/sys/unix/thread.rs

nagisa · 2021-09-24T10:56:57Z

library/std/src/sys/unix/process/process_unix.rs

@@ -409,7 +409,7 @@ impl Command {
        }

        // Only glibc 2.24+ posix_spawn() supports returning ENOENT directly.
-        #[cfg(all(target_os = "linux", target_env = "gnu"))]
+        #[cfg(all(target_os = "linux", any(target_env = "gnu", target_env = "uclibc")))]


From what I can tell uclibc does not implement gnu_get_libc_version so the code below will always return Ok(None) and, I guess, fallback to something simpler. Another thing is that this implementation of posix_spawn function is still behind cfg(target_env = !uclibc) so this change does nothing at all.

Ah, and to add, from what I can tell uClibc does implement posix_spawn so ideally it does get used, somewhow^^

Ok, I did some experiments, and uclibc does implement posix_spawn but it doesn't return ENOENT directly as required by this code. I will remove this condition within the function — the condition guarding the whole function is sufficient.

uclibc: fix semver files, add misc symbols This commit gets uclibc support working again, and fixes the semver lists to segregate gnu- and musl- specific symbols to those libc variants. There is a [separate PR](rust-lang/rust#88952) against rust itself to add armv7-unknown-linux-uclibceabihf as a tier 3 platform, and this commit is in support of that effort. Until that's done, we should not use the CI for that platform, but I'm including the CI file here in anticipation of turning it on in the not-too-distant future.

pgasiorowski · 2021-09-28T07:21:56Z

Has anybody tried compiling library/std for armv7-unknown-linux-uclibceabihf architecture already?

I built rust from this branch and then try to cross-compile library/std:

./x.py build --stage 1 --host x86_64-unknown-linux-gnu --target armv7-unknown-linux-uclibceabihf library/std

but I'm running into this error:

error[E0425]: cannot find value SYS_clone3 in this scope

with stage 0

./x.py build --stage 0 --target armv7-unknown-linux-uclibceabihf library/std

It seems even worse:

skrap · 2021-09-28T13:20:29Z

Has anybody tried compiling library/std for armv7-unknown-linux-uclibceabihf architecture already?

Yes. The issue is that you need a recent change to libc: rust-lang/libc#2403

It's in the latest libc (only released yesterday) so I guess I should update this PR to include a bump in the libc version in Config.toml.

skrap · 2021-09-28T13:23:11Z

@nagisa Thanks for the review! I will get to your comments above. @ykoehler may have some comments as well, as he is the author of the code in question.

pgasiorowski · 2021-09-28T19:20:46Z

Has anybody tried compiling library/std for armv7-unknown-linux-uclibceabihf architecture already?

Yes. The issue is that you need a recent change to libc: rust-lang/libc#2403

It's in the latest libc (only released yesterday) so I guess I should update this PR to include a bump in the libc version in Config.toml.

Thanks! I can confirm that updating this from 0.2.99 to 0.2.103 works and library/std builds fine.

Co-authored-by: Jonah Petri <[email protected]>

skrap · 2021-10-06T14:36:35Z

@rustbot ready

nagisa · 2021-10-08T11:20:17Z

@bors r+

bors · 2021-10-08T11:20:19Z

📌 Commit bd82172 has been approved by nagisa

bors · 2021-10-10T08:16:24Z

⌛ Testing commit bd82172 with merge 9e8356c...

bors · 2021-10-10T11:28:41Z

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing 9e8356c to master...

rust-timer · 2021-10-10T13:01:11Z

Finished benchmarking commit (9e8356c): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Pkgsrc changes: * Adapt a couple of patches Upstream changes: Version 1.57.0 (2021-12-02) ========================== Language -------- - [Macro attributes may follow `#[derive]` and will see the original (pre-`cfg`) input.][87220] - [Accept curly-brace macros in expressions, like `m!{ .. }.method()` and `m!{ .. }?`.][88690] - [Allow panicking in constant evaluation.][89508] Compiler -------- - [Create more accurate debuginfo for vtables.][89597] - [Add `armv6k-nintendo-3ds` at Tier 3\*.][88529] - [Add `armv7-unknown-linux-uclibceabihf` at Tier 3\*.][88952] - [Add `m68k-unknown-linux-gnu` at Tier 3\*.][88321] - [Add SOLID targets at Tier 3\*:][86191] `aarch64-kmc-solid_asp3`, `armv7a-kmc-solid_asp3-eabi`, `armv7a-kmc-solid_asp3-eabihf` \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Avoid allocations and copying in `Vec::leak`][89337] - [Add `#[repr(i8)]` to `Ordering`][89507] - [Optimize `File::read_to_end` and `read_to_string`][89582] - [Update to Unicode 14.0][89614] - [Many more functions are marked `#[must_use]`][89692], producing a warning when ignoring their return value. This helps catch mistakes such as expecting a function to mutate a value in place rather than return a new value. Stabilised APIs --------------- - [`[T; N]::as_mut_slice`][`array::as_mut_slice`] - [`[T; N]::as_slice`][`array::as_slice`] - [`collections::TryReserveError`] - [`HashMap::try_reserve`] - [`HashSet::try_reserve`] - [`String::try_reserve`] - [`String::try_reserve_exact`] - [`Vec::try_reserve`] - [`Vec::try_reserve_exact`] - [`VecDeque::try_reserve`] - [`VecDeque::try_reserve_exact`] - [`Iterator::map_while`] - [`iter::MapWhile`] - [`proc_macro::is_available`] - [`Command::get_program`] - [`Command::get_args`] - [`Command::get_envs`] - [`Command::get_current_dir`] - [`CommandArgs`] - [`CommandEnvs`] These APIs are now usable in const contexts: - [`hint::unreachable_unchecked`] Cargo ----- - [Stabilize custom profiles][cargo/9943] Compatibility notes ------------------- Internal changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Added an experimental backend for codegen with `libgccjit`.][87260] [86191]: rust-lang/rust#86191 [87220]: rust-lang/rust#87220 [87260]: rust-lang/rust#87260 [88243]: rust-lang/rust#88243 [88321]: rust-lang/rust#88321 [88529]: rust-lang/rust#88529 [88690]: rust-lang/rust#88690 [88952]: rust-lang/rust#88952 [89337]: rust-lang/rust#89337 [89507]: rust-lang/rust#89507 [89508]: rust-lang/rust#89508 [89582]: rust-lang/rust#89582 [89597]: rust-lang/rust#89597 [89614]: rust-lang/rust#89614 [89692]: rust-lang/rust#89692 [cargo/9943]: rust-lang/cargo#9943 [`array::as_mut_slice`]: https://doc.rust-lang.org/std/primitive.array.html#method.as_mut_slice [`array::as_slice`]: https://doc.rust-lang.org/std/primitive.array.html#method.as_slice [`collections::TryReserveError`]: https://doc.rust-lang.org/std/collections/struct.TryReserveError.html [`HashMap::try_reserve`]: https://doc.rust-lang.org/std/collections/hash_map/struct.HashMap.html#method.try_reserve [`HashSet::try_reserve`]: https://doc.rust-lang.org/std/collections/hash_set/struct.HashSet.html#method.try_reserve [`String::try_reserve`]: https://doc.rust-lang.org/alloc/string/struct.String.html#method.try_reserve [`String::try_reserve_exact`]: https://doc.rust-lang.org/alloc/string/struct.String.html#method.try_reserve_exact [`Vec::try_reserve`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.try_reserve [`Vec::try_reserve_exact`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.try_reserve_exact [`VecDeque::try_reserve`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.try_reserve [`VecDeque::try_reserve_exact`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.try_reserve_exact [`Iterator::map_while`]: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.map_while [`iter::MapWhile`]: https://doc.rust-lang.org/std/iter/struct.MapWhile.html [`proc_macro::is_available`]: https://doc.rust-lang.org/proc_macro/fn.is_available.html [`Command::get_program`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_program [`Command::get_args`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_args [`Command::get_envs`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_envs [`Command::get_current_dir`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_current_dir [`CommandArgs`]: https://doc.rust-lang.org/std/process/struct.CommandArgs.html [`CommandEnvs`]: https://doc.rust-lang.org/std/process/struct.CommandEnvs.html

Pkgsrc changes: * Adjust line numbers in a number of patches * remove the --disable-dist-src option, so that we produce the rust-src rust component, which we upload to LOCALSRC to allow the rust-src package to build, which is needed for rust-analyzer. * Cargo checksum for vendor/cc no longer needs patching; checksum for vendor/libc updated Upstream changes: Version 1.57.0 (2021-12-02) ========================== Language -------- - [Macro attributes may follow `#[derive]` and will see the original (pre-`cfg`) input.][87220] - [Accept curly-brace macros in expressions, like `m!{ .. }.method()` and `m!{ .. }?`.][88690] - [Allow panicking in constant evaluation.][89508] Compiler -------- - [Create more accurate debuginfo for vtables.][89597] - [Add `armv6k-nintendo-3ds` at Tier 3\*.][88529] - [Add `armv7-unknown-linux-uclibceabihf` at Tier 3\*.][88952] - [Add `m68k-unknown-linux-gnu` at Tier 3\*.][88321] - [Add SOLID targets at Tier 3\*:][86191] `aarch64-kmc-solid_asp3`, `armv7a-kmc-solid_asp3-eabi`, `armv7a-kmc-solid_asp3-eabihf` \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Avoid allocations and copying in `Vec::leak`][89337] - [Add `#[repr(i8)]` to `Ordering`][89507] - [Optimize `File::read_to_end` and `read_to_string`][89582] - [Update to Unicode 14.0][89614] - [Many more functions are marked `#[must_use]`][89692], producing a warning when ignoring their return value. This helps catch mistakes such as expecting a function to mutate a value in place rather than return a new value. Stabilised APIs --------------- - [`[T; N]::as_mut_slice`][`array::as_mut_slice`] - [`[T; N]::as_slice`][`array::as_slice`] - [`collections::TryReserveError`] - [`HashMap::try_reserve`] - [`HashSet::try_reserve`] - [`String::try_reserve`] - [`String::try_reserve_exact`] - [`Vec::try_reserve`] - [`Vec::try_reserve_exact`] - [`VecDeque::try_reserve`] - [`VecDeque::try_reserve_exact`] - [`Iterator::map_while`] - [`iter::MapWhile`] - [`proc_macro::is_available`] - [`Command::get_program`] - [`Command::get_args`] - [`Command::get_envs`] - [`Command::get_current_dir`] - [`CommandArgs`] - [`CommandEnvs`] These APIs are now usable in const contexts: - [`hint::unreachable_unchecked`] Cargo ----- - [Stabilize custom profiles][cargo/9943] Compatibility notes ------------------- Internal changes ---------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Added an experimental backend for codegen with `libgccjit`.][87260] [86191]: rust-lang/rust#86191 [87220]: rust-lang/rust#87220 [87260]: rust-lang/rust#87260 [88243]: rust-lang/rust#88243 [88321]: rust-lang/rust#88321 [88529]: rust-lang/rust#88529 [88690]: rust-lang/rust#88690 [88952]: rust-lang/rust#88952 [89337]: rust-lang/rust#89337 [89507]: rust-lang/rust#89507 [89508]: rust-lang/rust#89508 [89582]: rust-lang/rust#89582 [89597]: rust-lang/rust#89597 [89614]: rust-lang/rust#89614 [89692]: rust-lang/rust#89692 [cargo/9943]: rust-lang/cargo#9943 [`array::as_mut_slice`]: https://doc.rust-lang.org/std/primitive.array.html#method.as_mut_slice [`array::as_slice`]: https://doc.rust-lang.org/std/primitive.array.html#method.as_slice [`collections::TryReserveError`]: https://doc.rust-lang.org/std/collections/struct.TryReserveError.html [`HashMap::try_reserve`]: https://doc.rust-lang.org/std/collections/hash_map/struct.HashMap.html#method.try_reserve [`HashSet::try_reserve`]: https://doc.rust-lang.org/std/collections/hash_set/struct.HashSet.html#method.try_reserve [`String::try_reserve`]: https://doc.rust-lang.org/alloc/string/struct.String.html#method.try_reserve [`String::try_reserve_exact`]: https://doc.rust-lang.org/alloc/string/struct.String.html#method.try_reserve_exact [`Vec::try_reserve`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.try_reserve [`Vec::try_reserve_exact`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.try_reserve_exact [`VecDeque::try_reserve`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.try_reserve [`VecDeque::try_reserve_exact`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.try_reserve_exact [`Iterator::map_while`]: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.map_while [`iter::MapWhile`]: https://doc.rust-lang.org/std/iter/struct.MapWhile.html [`proc_macro::is_available`]: https://doc.rust-lang.org/proc_macro/fn.is_available.html [`Command::get_program`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_program [`Command::get_args`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_args [`Command::get_envs`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_envs [`Command::get_current_dir`]: https://doc.rust-lang.org/std/process/struct.Command.html#method.get_current_dir [`CommandArgs`]: https://doc.rust-lang.org/std/process/struct.CommandArgs.html [`CommandEnvs`]: https://doc.rust-lang.org/std/process/struct.CommandEnvs.html

rust-highfive assigned oli-obk Sep 15, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2021

This comment has been minimized.

Sign in to view

oli-obk mentioned this pull request Sep 15, 2021

Add new target armv7-unknown-linux-uclibceabihf #79380

Closed

oli-obk requested changes Sep 15, 2021

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2021

This comment has been minimized.

Sign in to view

skrap mentioned this pull request Sep 17, 2021

uclibc: fix semver files, add misc symbols rust-lang/libc#2403

Merged

skrap force-pushed the add-armv7-uclibc branch from b0ff890 to 27f5ccc Compare September 17, 2021 21:19

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 17, 2021

skrap marked this pull request as ready for review September 17, 2021 21:24

rust-highfive assigned Mark-Simulacrum and unassigned oli-obk Sep 18, 2021

skrap force-pushed the add-armv7-uclibc branch from 27f5ccc to 399882e Compare September 21, 2021 01:51

rust-highfive assigned nagisa and unassigned Mark-Simulacrum Sep 23, 2021

nagisa reviewed Sep 24, 2021

View reviewed changes

skrap force-pushed the add-armv7-uclibc branch from 53bc418 to 37ff34e Compare September 30, 2021 00:38

Yannick Koehler and others added 3 commits October 6, 2021 14:33

Add new target armv7-unknown-linux-uclibceabihf

11381a5

Co-authored-by: Jonah Petri <[email protected]>

add platform support details file for armv7-unknown-linux-uclibc

bc3eb35

Update libc to 0.2.103.

bd82172

skrap force-pushed the add-armv7-uclibc branch from 37ff34e to bd82172 Compare October 6, 2021 14:34

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 10, 2021

bors merged commit 9e8356c into rust-lang:master Oct 10, 2021

rustbot added this to the 1.57.0 milestone Oct 10, 2021

bors mentioned this pull request Oct 10, 2021

Add new tier 3 target: x86_64-unknown-none #89062

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new tier-3 target: armv7-unknown-linux-uclibceabihf #88952

Add new tier-3 target: armv7-unknown-linux-uclibceabihf #88952

skrap commented Sep 15, 2021

rust-highfive commented Sep 15, 2021

rust-highfive commented Sep 15, 2021

This comment has been minimized.

This comment has been minimized.

oli-obk left a comment

skrap commented Sep 15, 2021

Mark-Simulacrum commented Sep 15, 2021

rustbot commented Sep 15, 2021

This comment has been minimized.

skrap commented Sep 17, 2021

oli-obk commented Sep 18, 2021

bors commented Sep 20, 2021

Mark-Simulacrum commented Sep 23, 2021

skrap commented Sep 23, 2021

nagisa Sep 24, 2021

nagisa Sep 24, 2021

skrap Oct 6, 2021 •

edited

Loading

pgasiorowski commented Sep 28, 2021 •

edited

Loading

skrap commented Sep 28, 2021

skrap commented Sep 28, 2021

pgasiorowski commented Sep 28, 2021

skrap commented Oct 6, 2021

nagisa commented Oct 8, 2021

bors commented Oct 8, 2021

bors commented Oct 10, 2021

bors commented Oct 10, 2021

rust-timer commented Oct 10, 2021

Add new tier-3 target: armv7-unknown-linux-uclibceabihf #88952

Add new tier-3 target: armv7-unknown-linux-uclibceabihf #88952

Conversation

skrap commented Sep 15, 2021

rust-highfive commented Sep 15, 2021

rust-highfive commented Sep 15, 2021

This comment has been minimized.

This comment has been minimized.

oli-obk left a comment

Choose a reason for hiding this comment

skrap commented Sep 15, 2021

Mark-Simulacrum commented Sep 15, 2021

rustbot commented Sep 15, 2021

This comment has been minimized.

skrap commented Sep 17, 2021

oli-obk commented Sep 18, 2021

bors commented Sep 20, 2021

Mark-Simulacrum commented Sep 23, 2021

skrap commented Sep 23, 2021

nagisa Sep 24, 2021

Choose a reason for hiding this comment

nagisa Sep 24, 2021

Choose a reason for hiding this comment

skrap Oct 6, 2021 • edited Loading

Choose a reason for hiding this comment

pgasiorowski commented Sep 28, 2021 • edited Loading

skrap commented Sep 28, 2021

skrap commented Sep 28, 2021

pgasiorowski commented Sep 28, 2021

skrap commented Oct 6, 2021

nagisa commented Oct 8, 2021

bors commented Oct 8, 2021

bors commented Oct 10, 2021

bors commented Oct 10, 2021

rust-timer commented Oct 10, 2021

skrap Oct 6, 2021 •

edited

Loading

pgasiorowski commented Sep 28, 2021 •

edited

Loading