Split TypeVisitable from TypeFoldable #98206

eggyal · 2022-06-17T16:54:28Z

Impl of rust-lang/compiler-team#520 following MCP approval.

r? @ghost

compiler-errors · 2022-06-17T16:56:08Z

@bors try @rust-timer queue

jackh726 · 2022-06-17T16:56:08Z

@bors try @rust-timer queue

rust-timer · 2022-06-17T16:56:09Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-timer · 2022-06-17T16:56:10Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-06-17T16:56:17Z

⌛ Trying commit 02ffdd8a61a16e456b8ecca07b50a377fb4e6d0b with merge bad46eb863052b6f63aa85031bb6a6d8f52a5123...

compiler-errors · 2022-06-17T18:34:58Z

@bors try @rust-timer queue

rust-timer · 2022-06-17T18:34:59Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-06-17T18:35:07Z

⌛ Trying commit 2e616894f4abe8ad696a274478b8918032024f9f with merge fd426ee2bcc2183c3636c38927e5866d02146a13...

bors · 2022-06-17T20:35:17Z

☀️ Try build successful - checks-actions
Build commit: fd426ee2bcc2183c3636c38927e5866d02146a13 (fd426ee2bcc2183c3636c38927e5866d02146a13)

rust-timer · 2022-06-17T20:35:19Z

Queued fd426ee2bcc2183c3636c38927e5866d02146a13 with parent 43c47db, future comparison URL.

rust-timer · 2022-06-17T22:48:52Z

Finished benchmarking commit (fd426ee2bcc2183c3636c38927e5866d02146a13): comparison url.

Instruction count

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	0.6%	0.7%	2
Regressions 😿 (secondary)	1.2%	1.6%	7
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	0.6%	0.7%	2

Max RSS (memory usage)

Results

Primary benchmarks: 🎉 relevant improvements found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	4.4%	4.4%	1
Improvements 🎉 (primary)	-1.7%	-2.4%	2
Improvements 🎉 (secondary)	-2.7%	-2.9%	2
All 😿🎉 (primary)	-1.7%	-2.4%	2

Cycles

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: no relevant changes found

	mean¹	max	count²
Regressions 😿 (primary)	2.4%	2.4%	1
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	2.4%	2.4%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

eggyal · 2022-06-18T02:39:35Z

Cachegrind diff of worst performing benchmark (keccak Check Full)

--------------------------------------------------------------------------------
Files compared:   results/cgfilt-43c47db0b04627dbd0e16a1e7cad14a4a5a60d3a-keccak-Check-Full; results/cgfilt-fd426ee2bcc2183c3636c38927e5866d02146a13-keccak-Check-Full
Command:          /usr/local/rustup/toolchains/43c47db0b04627dbd0e16a1e7cad14a4a5a60d3a/bin/rustc --crate-name keccak src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata -C embed-bitcode=no -C debuginfo=2 -C metadata=7e4bc056058c3e31 -C extra-filename=-7e4bc056058c3e31 --out-dir /tmp/.tmpQs7GQY/target/debug/deps -L dependency=/tmp/.tmpQs7GQY/target/debug/deps -Adeprecated -Aunknown-lints -Zincremental-verify-ich; /usr/local/rustup/toolchains/fd426ee2bcc2183c3636c38927e5866d02146a13/bin/rustc --crate-name keccak src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata -C embed-bitcode=no -C debuginfo=2 -C metadata=7e4bc056058c3e31 -C extra-filename=-7e4bc056058c3e31 --out-dir /tmp/.tmpYRLPG5/target/debug/deps -L dependency=/tmp/.tmpYRLPG5/target/debug/deps -Adeprecated -Aunknown-lints -Zincremental-verify-ich
Data file:        results/cgfilt-diff-43c47db0b04627dbd0e16a1e7cad14a4a5a60d3a-fd426ee2bcc2183c3636c38927e5866d02146a13-keccak-Check-Full
Events recorded:  Ir
Events shown:     Ir
Event sort order: Ir
Thresholds:       0.1
Include dirs:     
User annotated:   
Auto-annotation:  on

--------------------------------------------------------------------------------
Ir          
--------------------------------------------------------------------------------
327,046,501  PROGRAM TOTALS

--------------------------------------------------------------------------------
Ir           file:function
--------------------------------------------------------------------------------
322,018,655  ???:<rustc_data_structures::obligation_forest::ObligationForest<rustc_trait_selection::traits::fulfill::PendingPredicateObligation>>::process_obligations::<rustc_trait_selection::traits::fulfill::FulfillProcessor, rustc_data_structures::obligation_forest::Outcome<rustc_trait_selection::traits::fulfill::PendingPredicateObligation, rustc_infer::traits::FulfillmentErrorCode>>
 71,953,113  ???:<rustc_middle::ty::Ty as rustc_middle::ty::fold::TypeSuperFoldable>::super_fold_with::<rustc_infer::infer::resolve::OpportunisticVarResolver>
-66,339,597  ???:<rustc_infer::infer::resolve::OpportunisticVarResolver as rustc_middle::ty::fold::TypeFolder>::fold_ty
 16,425,516  ???:<rustc_infer::infer::InferCtxt>::commit_if_ok::<(), (), rustc_trait_selection::traits::project::assemble_candidates_from_impls::{closure
-14,072,523  ???:rustc_trait_selection::traits::project::opt_normalize_projection_type
-11,939,128  ???:<rustc_middle::ty::Predicate as rustc_middle::ty::fold::TypeFoldable>::has_type_flags
 11,939,128  ???:<rustc_middle::ty::Predicate as rustc_middle::ty::visit::TypeVisitable>::has_type_flags
 -9,706,118  ???:<&rustc_middle::ty::list::List<rustc_middle::ty::subst::GenericArg> as rustc_middle::ty::fold::TypeFoldable>::try_fold_with::<rustc_infer::infer::resolve::OpportunisticVarResolver>
  6,686,712  ???:<rustc_infer::infer::ShallowResolver as rustc_middle::ty::fold::TypeFolder>::fold_ty
  6,262,100  ???:<rustc_infer::infer::resolve::OpportunisticVarResolver as rustc_middle::ty::fold::FallibleTypeFolder>::try_fold_ty
  5,455,662  ???:<rustc_privacy::DefIdVisitorSkeleton<rustc_privacy::TypePrivacyVisitor> as rustc_middle::ty::visit::TypeVisitor>::visit_ty
 -5,455,662  ???:<rustc_privacy::DefIdVisitorSkeleton<rustc_privacy::TypePrivacyVisitor> as rustc_middle::ty::fold::TypeVisitor>::visit_ty
  5,261,136  ???:<rustc_infer::infer::canonical::canonicalizer::Canonicalizer as rustc_middle::ty::fold::FallibleTypeFolder>::try_fold_predicate
 -4,513,722  ???:<rustc_middle::ty::consts::Const as rustc_middle::ty::fold::TypeFoldable>::try_fold_with::<rustc_middle::ty::fold::RegionFolder>
 -4,490,567  ???:<rustc_infer::infer::InferCtxt as rustc_trait_selection::traits::query::evaluate_obligation::InferCtxtExt>::predicate_may_hold
  4,349,756  ???:<rustc_middle::ty::fold::RegionFolder as rustc_middle::ty::fold::FallibleTypeFolder>::try_fold_const
 -3,319,872  ???:<&rustc_middle::ty::list::List<rustc_middle::ty::Ty> as rustc_middle::ty::fold::TypeFoldable>::try_fold_with::<rustc_infer::infer::resolve::OpportunisticVarResolver>
 -3,219,560  ???:<rustc_infer::infer::resolve::OpportunisticVarResolver as rustc_middle::ty::fold::FallibleTypeFolder>::try_fold_const
  2,892,198  ???:<rustc_middle::ty::PredicateKind as rustc_middle::ty::visit::TypeVisitable>::has_escaping_bound_vars
 -2,892,198  ???:<rustc_middle::ty::PredicateKind as rustc_middle::ty::fold::TypeFoldable>::has_escaping_bound_vars
  2,792,321  ???:<rustc_data_structures::snapshot_map::SnapshotMap<rustc_infer::traits::project::ProjectionCacheKey, rustc_infer::traits::project::ProjectionCacheEntry, &mut std::collections::hash::map::HashMap<rustc_infer::traits::project::ProjectionCacheKey, rustc_infer::traits::project::ProjectionCacheEntry, core::hash::BuildHasherDefault<rustc_hash::FxHasher>>, &mut rustc_infer::infer::undo_log::InferCtxtUndoLogs>>::insert
  2,753,996  ???:<rustc_infer::infer::InferCtxt>::probe::<core::result::Result<rustc_middle::traits::select::EvaluationResult, rustc_middle::traits::select::OverflowError>, rustc_trait_selection::traits::relationships::update<rustc_trait_selection::traits::fulfill::FulfillmentContext>::{closure
 -2,237,804  ???:<rustc_infer::traits::project::ProjectionCache>::ambiguous
 -2,094,401  ???:<rustc_trait_selection::traits::fulfill::FulfillmentContext as rustc_infer::traits::engine::TraitEngine>::register_predicate_obligation
  1,693,200  ???:<rustc_infer::infer::InferCtxt>::shallow_resolve::<rustc_middle::ty::consts::Const>
  1,533,556  ???:<rustc_middle::ty::Predicate as rustc_middle::ty::visit::TypeVisitable>::has_vars_bound_at_or_above
 -1,533,556  ???:<rustc_middle::ty::Predicate as rustc_middle::ty::fold::TypeFoldable>::has_vars_bound_at_or_above
  1,379,662  ???:<rustc_middle::ty::fold::RegionFolder as rustc_middle::ty::fold::FallibleTypeFolder>::try_fold_ty
 -1,228,990  ???:<rustc_middle::ty::Ty as rustc_middle::ty::fold::TypeSuperFoldable>::super_fold_with::<rustc_middle::ty::fold::RegionFolder>
 -1,012,901  ???:<rustc_borrowck::type_check::TypeChecker>::typeck_mir
    932,832  ???:<rustc_typeck::check::fn_ctxt::FnCtxt>::adjust_steps_as_infer_ok
   -917,540  ???:<hashbrown::raw::RawTable<(rustc_middle::ty::context::InternedInSet<rustc_middle::ty::list::List<rustc_middle::ty::subst::GenericArg>>, ())>>::reserve_rehash::<hashbrown::map::make_hasher<rustc_middle::ty::context::InternedInSet<rustc_middle::ty::list::List<rustc_middle::ty::subst::GenericArg>>, rustc_middle::ty::context::InternedInSet<rustc_middle::ty::list::List<rustc_middle::ty::subst::GenericArg>>, (), core::hash::BuildHasherDefault<rustc_hash::FxHasher>>::{closure
   -863,158  ???:<rustc_middle::ty::consts::Const as rustc_middle::ty::fold::TypeFoldable>::visit_with::<rustc_privacy::DefIdVisitorSkeleton<rustc_privacy::TypePrivacyVisitor>>
    863,158  ???:<rustc_middle::ty::consts::Const as rustc_middle::ty::visit::TypeVisitable>::visit_with::<rustc_privacy::DefIdVisitorSkeleton<rustc_privacy::TypePrivacyVisitor>>
   -859,237  ???:<rustc_borrowck::type_check::TypeVerifier as rustc_middle::mir::visit::Visitor>::visit_body
   -749,616  ???:<rustc_infer::infer::canonical::canonicalizer::Canonicalizer>::canonicalize::<rustc_middle::ty::ParamEnvAnd<rustc_middle::ty::Predicate>>
   -716,961  ???:<rustc_trait_selection::traits::fulfill::FulfillProcessor>::process_changed_obligations
   -708,192  ???:<alloc::vec::Vec<rustc_middle::ty::adjustment::Adjustment> as alloc::vec::spec_from_iter::SpecFromIter<rustc_middle::ty::adjustment::Adjustment, core::iter::adapters::map::Map<core::iter::adapters::zip::Zip<core::iter::adapters::map::Map<core::slice::iter::Iter<(rustc_middle::ty::Ty, rustc_trait_selection::autoderef::AutoderefKind)>, <rustc_typeck::check::fn_ctxt::FnCtxt>::adjust_steps_as_infer_ok::{closure
   -675,176  ???:<rustc_middle::ty::Ty as rustc_middle::ty::fold::TypeFoldable>::try_fold_with::<rustc_infer::infer::resolve::OpportunisticVarResolver>
   -619,248  ???:<rustc_typeck::check::fn_ctxt::FnCtxt>::check_expr_kind
    619,152  ???:<rustc_infer::infer::InferCtxt as rustc_trait_selection::infer::InferCtxtExt>::partially_normalize_associated_types_in::<rustc_middle::ty::sty::FnSig>
    618,428  ???:<rustc_mir_build::build::CFG>::push_assign_unit
    584,196  ???:<rustc_borrowck::borrow_set::BorrowSet>::build
   -572,468  ???:<rustc_middle::ty::consts::Const as rustc_middle::ty::fold::TypeFoldable>::try_fold_with::<rustc_infer::infer::resolve::OpportunisticVarResolver>
   -467,868  ???:rustc_data_structures::graph::dominators::dominators::<&rustc_middle::mir::Body>
   -457,124  ???:<rustc_mir_build::build::Builder>::ast_block_stmts
    418,704  ???:rustc_middle::ty::util::fold_list::<rustc_trait_selection::traits::project::AssocTypeNormalizer, rustc_middle::ty::Ty, <&rustc_middle::ty::list::List<rustc_middle::ty::Ty> as rustc_middle::ty::fold::TypeFoldable>::try_fold_with<rustc_trait_selection::traits::project::AssocTypeNormalizer>::{closure
    418,198  ???:<rustc_middle::ty::context::CtxtInterners>::intern_predicate
    401,184  ???:<rustc_middle::ty::sty::EarlyBinder<rustc_middle::ty::sty::Binder<rustc_middle::ty::sty::FnSig>> as rustc_middle::ty::subst::Subst>::subst
    396,704  ???:<rustc_middle::ty::Ty as rustc_middle::ty::visit::TypeVisitable>::visit_with::<rustc_privacy::DefIdVisitorSkeleton<rustc_privacy::TypePrivacyVisitor>>
   -396,704  ???:<rustc_middle::ty::Ty as rustc_middle::ty::fold::TypeFoldable>::visit_with::<rustc_privacy::DefIdVisitorSkeleton<rustc_privacy::TypePrivacyVisitor>>
    392,904  ???:<rustc_infer::infer::InferCtxt>::replace_bound_vars_with_fresh_vars::<rustc_middle::ty::sty::FnSig>
    387,849  ???:<alloc::vec::Vec<(rustc_ast::tokenstream::TokenTree, rustc_ast::tokenstream::Spacing)> as core::ops::drop::Drop>::drop
   -376,916  ???:<alloc::rc::Rc<alloc::vec::Vec<(rustc_ast::tokenstream::TokenTree, rustc_ast::tokenstream::Spacing)>> as core::ops::drop::Drop>::drop
   -367,642  ???:<rustc_data_structures::obligation_forest::ObligationForest<rustc_trait_selection::traits::fulfill::PendingPredicateObligation>>::apply_rewrites
   -366,333  ???:_rjem_je_eset_fit
    344,416  ???:<rustc_middle::ty::Ty as rustc_middle::ty::visit::TypeVisitable>::visit_with::<<rustc_middle::ty::context::TyCtxt>::any_free_region_meets::RegionVisitor<<rustc_middle::ty::context::TyCtxt>::all_free_regions_meet<rustc_middle::ty::Ty, rustc_borrowck::type_check::liveness::compute_live_locals::{closure
   -344,416  ???:<rustc_middle::ty::Ty as rustc_middle::ty::fold::TypeFoldable>::visit_with::<<rustc_middle::ty::context::TyCtxt>::any_free_region_meets::RegionVisitor<<rustc_middle::ty::context::TyCtxt>::all_free_regions_meet<rustc_middle::ty::Ty, rustc_borrowck::type_check::liveness::compute_live_locals::{closure
   -328,320  ???:<rustc_middle::ty::sty::ProjectionTy as rustc_middle::ty::fold::TypeFoldable>::try_fold_with::<rustc_infer::infer::resolve::OpportunisticVarResolver>

compiler-errors · 2022-06-18T02:45:01Z

Looks just like inliner shenanigans...

eggyal · 2022-06-18T14:56:00Z

Rebased off #98219.

jackh726 · 2022-06-18T23:46:18Z

I'm inclined to let the MCP sit for a few more days, (maybe until after Thursday's compiler meeting), but otherwise feel good about merging this.

Need to "actually" review this though before merge.

bors · 2022-06-19T15:21:48Z

☔ The latest upstream changes (presumably #98238) made this pull request unmergeable. Please resolve the merge conflicts.

eggyal · 2022-07-06T05:47:26Z

@bors r=jackh726 p=1

bors · 2022-07-06T05:47:28Z

@eggyal: 🔑 Insufficient privileges: Not in reviewers

bors · 2022-07-06T05:47:29Z

@eggyal: 🔑 Insufficient privileges: not in try users

jackh726 · 2022-07-06T05:48:04Z

@bors r+

bors · 2022-07-06T05:48:05Z

📌 Commit 4f0a647 has been approved by jackh726

bors · 2022-07-06T05:48:19Z

⌛ Testing commit 4f0a647 with merge 5b8cf49...

rust-log-analyzer · 2022-07-06T05:57:29Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2022-07-06T08:29:05Z

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 5b8cf49 to master...

rust-timer · 2022-07-06T09:45:41Z

Finished benchmarking commit (5b8cf49): comparison url.

Instruction count

Primary benchmarks: mixed results
Secondary benchmarks: 🎉 relevant improvements found

	mean¹	max	count²
Regressions 😿 (primary)	0.7%	0.7%	1
Regressions 😿 (secondary)	1.0%	1.0%	1
Improvements 🎉 (primary)	-0.7%	-0.9%	8
Improvements 🎉 (secondary)	-1.4%	-2.3%	17
All 😿🎉 (primary)	-0.5%	-0.9%	9

Max RSS (memory usage)

Results

Primary benchmarks: 🎉 relevant improvement found
Secondary benchmarks: 🎉 relevant improvements found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-0.1%	-0.1%	1
Improvements 🎉 (secondary)	-2.6%	-2.8%	3
All 😿🎉 (primary)	-0.1%	-0.1%	1

Cycles

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 🎉 relevant improvements found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.4%	-2.6%	2
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

Summary: It includes this fix which was backported to 1.62.1. rust-lang/rust#98950 `2022-08-06` is what will become 1.64.0. Changes are caused by: - Split TypeVisitable from TypeFoldable: rust-lang/rust#98206 - Remove `fn backtrace` and replace with usages of provider API: rust-lang/rust#99431 Reviewed By: stepancheg Differential Revision: D39277984 fbshipit-source-id: 5afc6c2b9e5ee3074ea0ede995868aef12cebf14

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 17, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 17, 2022

This comment has been minimized.

Sign in to view

eggyal force-pushed the align-to-chalk-folding-api branch from 02ffdd8 to 2e61689 Compare June 17, 2022 18:32

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 17, 2022

eggyal force-pushed the align-to-chalk-folding-api branch from 2e61689 to db21add Compare June 18, 2022 14:53

eggyal changed the title ~~[PERF] Split TypeVisitable from TypeFoldable~~ Split TypeVisitable from TypeFoldable Jun 18, 2022

eggyal mentioned this pull request Jun 19, 2022

Rename folding/visiting traits rust-lang/chalk#767

Merged

eggyal force-pushed the align-to-chalk-folding-api branch from db21add to 5fd3a9f Compare June 19, 2022 17:53

eggyal force-pushed the align-to-chalk-folding-api branch from 3987b32 to 4f0a647 Compare July 6, 2022 05:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 6, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 6, 2022

bors merged commit 5b8cf49 into rust-lang:master Jul 6, 2022

rustbot added this to the 1.64.0 milestone Jul 6, 2022

eggyal deleted the align-to-chalk-folding-api branch July 6, 2022 09:09

Mark-Simulacrum removed the perf-regression Performance regression. label Jul 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split TypeVisitable from TypeFoldable #98206

Split TypeVisitable from TypeFoldable #98206

eggyal commented Jun 17, 2022 •

edited

Loading

compiler-errors commented Jun 17, 2022

jackh726 commented Jun 17, 2022

rust-timer commented Jun 17, 2022

rust-timer commented Jun 17, 2022

bors commented Jun 17, 2022

This comment has been minimized.

compiler-errors commented Jun 17, 2022

rust-timer commented Jun 17, 2022

bors commented Jun 17, 2022

This comment has been minimized.

bors commented Jun 17, 2022

rust-timer commented Jun 17, 2022

rust-timer commented Jun 17, 2022

eggyal commented Jun 18, 2022

compiler-errors commented Jun 18, 2022

eggyal commented Jun 18, 2022

jackh726 commented Jun 18, 2022

bors commented Jun 19, 2022

eggyal commented Jul 6, 2022

bors commented Jul 6, 2022

bors commented Jul 6, 2022

jackh726 commented Jul 6, 2022

bors commented Jul 6, 2022

bors commented Jul 6, 2022

rust-log-analyzer commented Jul 6, 2022

bors commented Jul 6, 2022

rust-timer commented Jul 6, 2022

Split TypeVisitable from TypeFoldable #98206

Split TypeVisitable from TypeFoldable #98206

Conversation

eggyal commented Jun 17, 2022 • edited Loading

compiler-errors commented Jun 17, 2022

jackh726 commented Jun 17, 2022

rust-timer commented Jun 17, 2022

rust-timer commented Jun 17, 2022

bors commented Jun 17, 2022

This comment has been minimized.

compiler-errors commented Jun 17, 2022

rust-timer commented Jun 17, 2022

bors commented Jun 17, 2022

This comment has been minimized.

bors commented Jun 17, 2022

rust-timer commented Jun 17, 2022

rust-timer commented Jun 17, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

eggyal commented Jun 18, 2022

compiler-errors commented Jun 18, 2022

eggyal commented Jun 18, 2022

jackh726 commented Jun 18, 2022

bors commented Jun 19, 2022

eggyal commented Jul 6, 2022

bors commented Jul 6, 2022

bors commented Jul 6, 2022

jackh726 commented Jul 6, 2022

bors commented Jul 6, 2022

bors commented Jul 6, 2022

rust-log-analyzer commented Jul 6, 2022

bors commented Jul 6, 2022

rust-timer commented Jul 6, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

eggyal commented Jun 17, 2022 •

edited

Loading