Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port status page to Vue #1675

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Port status page to Vue #1675

merged 1 commit into from
Sep 10, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jul 27, 2023

This will make it easier to make changes (e.g. to fix issue #1665). This PR first ports the status page as it was (apart from some tiny code changes, or removing cruft that's no longer relevant, like try commits without a proper date), I will make further changes in follow-up PRs.

To test this, it will probably be easiest to use data from the live server, by changing BASE_URL in site/frontend/urls.ts to this:

const BASE_URL = "https://perf.rust-lang.org/perf";

Then you can open the page locally and on the live server and compare that if it looks the same (it should) :)

@Kobzol Kobzol requested a review from lqd August 3, 2023 09:37
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test this, it will probably be easiest to use data from the live server

Yeah agreed, but that also means there was a limit in the number of states I could check: I couldn't easily compare benchmark errors, some states like both "collection in-progress" and "collection complete", the "empty queue" state, missing commits, etc 😓

But it's ok. We'll keep an eye on these rarer states and see if we missed anything then. It should be easy to fix if we can reproduce issues when they happen. The main Status functionality works great, so that's the most important use cases taken care of.

site/frontend/src/pages/status/page.vue Outdated Show resolved Hide resolved
site/frontend/src/pages/status/page.vue Show resolved Hide resolved
@Kobzol Kobzol requested a review from lqd September 9, 2023 19:42
@Kobzol Kobzol merged commit 36c3684 into rust-lang:master Sep 10, 2023
9 checks passed
@Kobzol Kobzol deleted the statue-page-vue branch September 10, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants