Switch to smaller instance type #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ran into long QUEUED times with the larger instances, and in testing it seems like the smaller instance type isn't actually significantly slower, and is 2x less expensive, so we should switch to it anyway. This also bumps the build timeout to give us a bit more buffer (our builds are currently just under 2 hours).
jdno
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into long QUEUED times with the larger instances, and in testing it seems like the smaller instance type isn't actually significantly slower, and is 2x less expensive, so we should switch to it anyway.
This also bumps the build timeout to give us a bit more buffer (our builds are currently just under 2 hours).
These changes have already been applied as part of fixing nightly promotions.