Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove users without a team from GitHub #84

Open
jdno opened this issue Sep 17, 2024 · 9 comments · May be fixed by #91
Open

Remove users without a team from GitHub #84

jdno opened this issue Sep 17, 2024 · 9 comments · May be fixed by #91
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jdno
Copy link
Member

jdno commented Sep 17, 2024

Right now, we invite new users to the rust-lang GitHub organization when they are added to a team. Eventually, they might stop contributing to the team and leave it again. When that happens, they are removed from the team in the rust-lang/team repo.

When a user is no longer part of any team or working group, we should also remove them from the rust-lang GitHub organization. This a) cleans up the members of the organization, making it easier to manage and review them. And b) frees up seats in the organization. The latter will become more relevant in the future, when admins will need to manually add seats in case we run out of our current allocation.

@jdno jdno added this to infra-team Sep 17, 2024
@github-project-automation github-project-automation bot moved this to Backlog in infra-team Sep 17, 2024
@MarcoIeni MarcoIeni added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 8, 2024
@me-diru
Copy link

me-diru commented Oct 10, 2024

Interesting, I was going through how membership in Rust GitHub Org works and it seems alumni are still kept in the GitHub org?

Source: https://forge.rust-lang.org/compiler/membership.html#alumni-status

Maybe it has changed now, and would love to get more insights on this :D

@jdno
Copy link
Member Author

jdno commented Oct 10, 2024

Yes, right now they are still kept in the GitHub organization. But that's what we want/need to change, since it becomes unsustainable with time.

@georgegarrington
Copy link

Hey, I would like to work on this - having a look at it now

@MarcoIeni
Copy link
Member

MarcoIeni commented Oct 10, 2024

Personal notes

This is what we need: https://docs.github.com/en/rest/orgs/members?apiVersion=2022-11-28#remove-an-organization-member

What we want to do is:

  1. Call the GitHub api to get the list of members of the org
  2. Diff against team members of the teams of the SyncGitHub. We don't want to use team.members of the GitHubTeam struct because we want toml data, not what's in GitHub

@MarcoIeni
Copy link
Member

MarcoIeni commented Oct 21, 2024

Hey @georgegarrington thanks for your help on this 🙏
Do you plan to finalize the work on #88 or should we continue from there?

@georgegarrington
Copy link

@MarcoIeni hi Marco still up for doing this however I won't have time right now so feel free to re-assign if necessary

@MarcoIeni
Copy link
Member

Ok, don't worry and thanks again for your help :)

If someone else wants to pick this, let us know.
Otherwise, feel free to work on it when you feel like!

@me-diru
Copy link

me-diru commented Oct 21, 2024

Hey @MarcoIeni !.
I wanna try giving this a shot :D

@MarcoIeni
Copy link
Member

MarcoIeni commented Oct 21, 2024

Go for it! 😁 I assigned the issue to you 👍

If you need anything, just ask!

@me-diru me-diru linked a pull request Oct 31, 2024 that will close this issue
@MarcoIeni MarcoIeni moved this from Backlog to In Progress in infra-team Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

4 participants