"review-submitted" automation does not work

[RalfJung]

We have added this to our triagebot.toml in Miri in the hopes of getting automatic labels when submitting a "changes requested" review:

[review-submitted]
# This label is added when a "request changes" review is submitted.
reviewed_label = "S-waiting-on-author"
# These labels are removed when a "request changes" review is submitted.
review_labels = ["S-waiting-on-review"]

However, this does not seem to work -- I submitted such a review in rust-lang/miri#4054, and the labels were not updated.

We copied the config here from the Rust repo. This slightly different than what the documentation says:

[review-submitted]
# These labels are removed when a review is submitted.
review_labels = ["S-waiting-on-review"]
# This label is added when a review is submitted.
reviewed_label = ["S-waiting-on-author"]

In the docs, reviewed_label is still a list, even though the name is singular -- that's confusing. Not sure if the docs are right or the rustc repo is right?

[RalfJung]

Looking at

triagebot/src/config.rs

Line 305 in d7d4bab

pub(crate) reviewed_label: String,

it seems like the docs are wrong here. So the Miri config should be right -- but it doesn't work.

Cc @oli-obk

EDIT: I fixed the docs in rust-lang/rust-forge#784.

[ehuss]

@RalfJung Does rust-lang/rust-forge#784 resolve this issue?

[RalfJung]

That fixes the docs. But the feature still just doesn't seem to work in the Miri repo.

[ehuss]

You must be an assignee for it to work. rust-lang/miri#4054 has no assignees.

[RalfJung]

Oh, I see. I didn't expect that, and the docs don't seem to mention it.

In Miri we typically don't use assignees. Is there any way to lift this restriction, and apply the label change whenever the review was submitted by someone who could be an assignee (i.e., by a project member)?