Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use libc's seccomp-related constants #60

Closed
boustrophedon opened this issue Sep 11, 2023 · 0 comments · Fixed by #71
Closed

Use libc's seccomp-related constants #60

boustrophedon opened this issue Sep 11, 2023 · 0 comments · Fixed by #71

Comments

@boustrophedon
Copy link
Contributor

As mentioned in #58 once rust-lang/libc#3343 lands we should use libc's constants instead of redefining them.

https://github.com/rust-vmm/seccompiler/blob/main/src/backend/bpf.rs#L116
and SECCOMP_SET_MODE_FILTER which is being added to lib.rs in #58
boustrophedon added a commit to boustrophedon/seccompiler that referenced this issue Mar 4, 2024
@boustrophedon
Use libc values for seccomp constants
3eea65f 
Now that rust-lang/libc/pull/3343 is merged and released, switch to
using libc's constants.

SECCOMP_RET_MASK does not exist anymore and appears to have not existed
for a while. SECCOMP_RET_DATA is exactly the same mask value, and the
usage here is in line with the man page.

Fixes rust-vmm#60
@boustrophedon boustrophedon mentioned this issue Mar 4, 2024
Merged
4 tasks
boustrophedon added a commit to boustrophedon/seccompiler that referenced this issue Mar 4, 2024
@boustrophedon
Use libc seccomp constants
c4122ae 
Use libc constants now that rust-lang/libc/pull/3343 is merged and
released.

SECCOMP_RET_MASK does not exist anymore and appears to have not existed
for a while. SECCOMP_RET_DATA is exactly the same mask value, and the
usage here is in line with the man page.

Completes rust-vmm#60

Signed-off-by: Harry Stern <[email protected]>
boustrophedon added a commit to boustrophedon/seccompiler that referenced this issue Mar 5, 2024
@boustrophedon
Use libc seccomp constants
a7a9a7b 
Use libc constants now that rust-lang/libc/pull/3343 is merged and
released.

SECCOMP_RET_MASK does not exist anymore and appears to have not existed
for a while. SECCOMP_RET_DATA is exactly the same mask value, and the
usage here is in line with the man page.

Completes rust-vmm#60

Signed-off-by: Harry Stern <[email protected]>
alindima pushed a commit that referenced this issue Mar 18, 2024
@boustrophedon @alindima
Use libc seccomp constants
b6907ec 
Use libc constants now that rust-lang/libc/pull/3343 is merged and
released.

SECCOMP_RET_MASK does not exist anymore and appears to have not existed
for a while. SECCOMP_RET_DATA is exactly the same mask value, and the
usage here is in line with the man page.

Completes #60

Signed-off-by: Harry Stern <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Libc update boustrophedon/seccompiler
1 participant
@boustrophedon