Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #6

Merged
merged 3 commits into from
Jan 28, 2021
Merged

Update dependencies #6

merged 3 commits into from
Jan 28, 2021

Conversation

qwandor-google
Copy link

@qwandor-google qwandor-google commented Sep 28, 2020 •
edited
Loading

This also fixes the vm target in the Makefile to work with QEMU 5.1, and an issue with building on 32-bit Android targets.

@qwandor-google
Copy link
Author

Hi, can I get a review on this please?

@elmarco
Copy link

elmarco commented Jan 19, 2021 •
edited
Loading

lgtm

@fsyncd @dpeckett same issue here. Please apply & release.

@jeromegn
Copy link

I also need this

@elmarco
Copy link

elmarco commented Jan 28, 2021

@Tim-Zhang your next merge? thanks :)

@Tim-Zhang
Copy link
Contributor

@qwandor-google Thanks a lot, can you withdraw the version increment commit? I plan to include more fixes in the version 0.2.2. I will bump the version a couple of days after the pr merged.

@qwandor
Add disable-legacy=on to QEMU command line.
cc19ecd 
This seems to be required for vhost-vsock-pci on QEMU 5.1.
@qwandor
Use socklen_t rather than u32, as they are not always the same.
866064d 
e.g. on 32-bit Android targets.
@qwandor
Update dependencies.
97a3299
@qwandor-google
Copy link
Author

Done.

There are unfortunately some warnings due to rust-lang/libc#1848 which I'm not sure how to avoid, if we update libc further.

@Tim-Zhang
Copy link
Contributor

Tim-Zhang commented Jan 28, 2021 •
edited
Loading

There are unfortunately some warnings due to rust-lang/libc#1848 which I'm not sure how to avoid, if we update libc further.

@qwandor-google Thanks, I have just fixed this issue #7

Tim-Zhang
Tim-Zhang approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@Tim-Zhang Tim-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qwandor-google LGTM, Thanks, Maybe I can publish it tomorrow.

@Tim-Zhang Tim-Zhang merged commit 370836c into rust-vsock:master Jan 28, 2021
@Tim-Zhang Tim-Zhang changed the title Update dependencies and increment version number Update dependencies Jan 28, 2021
@Tim-Zhang
Copy link
Contributor

@qwandor-google @jeromegn @elmarco I have published the version 0.2.2.

raoulstrackx added a commit to raoulstrackx/vsock-rs that referenced this pull request Dec 15, 2021
@raoulstrackx
Merge pull request rust-vsock#6 from raoulstrackx/raoul/getrandom_update
a090e2a 
Update `getrandom` crate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim-Zhang Tim-Zhang Tim-Zhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qwandor-google @elmarco @jeromegn @Tim-Zhang @qwandor