Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queston about one event struct #1627

Closed
InnocentusLime opened this issue Jul 18, 2020 · 2 comments
Closed

Queston about one event struct #1627

InnocentusLime opened this issue Jul 18, 2020 · 2 comments
Labels
F - duplicate This issue or pull request already exists

Comments

@InnocentusLime
Copy link

I've been looking through docs for WindowEvent and found the following definiton:

ScaleFactorChanged {
    scale_factor: f64,
    new_inner_size: &'a mut PhysicalSize<u32>,
},

I have several questions

  1. Why is new_inner_size a mutable reference? That seems really weird
  2. Why is it a reference at all? Why not just make it a value?

If there are no reasons, I'd like to make a PR to fix that... After all it will potentially make WindowEvent 'static + Clone + Copy. Not only that. It seems like the whole Event struct will become Clone + 'static. Maybe even Copy!
@kchibisov kchibisov transferred this issue from rust-windowing/glutin Jul 18, 2020
@kchibisov
Copy link
Member

duplicate of #1387

@kchibisov kchibisov added the F - duplicate This issue or pull request already exists label Jul 18, 2020
@kchibisov
Copy link
Member

There were some work to resolve that but it seems like it got stalled.

#1456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F - duplicate This issue or pull request already exists
Milestone
No milestone
Development

No branches or pull requests
2 participants
@InnocentusLime @kchibisov