Avoid running wasm-opt indefinitely #1191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POSIX says [1]: > If a file is removed from or added to the directory after the most recent > call to opendir() or rewinddir(), whether a subsequent call to readdir() > returns an entry for that file is unspecified. Writing `wasm-opt` output, renaming in a same directory being `readdir()`-ed is unspecified, and can cause the `readdir()` to loop indefinitely on certain filesystems. Fix it by collecting `readdir()` result first before making changes to the directory. Resolves rustwasm#1190. [1]: https://pubs.opengroup.org/onlinepubs/9699919799/functions/readdir.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSIX says 1:
Writing
wasm-optoutput, renaming in a same directory beingreaddir()-ed is unspecified, and can cause thereaddir()to loop indefinitely on certain filesystems.Fix it by collecting
readdir()result first before making changes to the directory.Resolves #1190.
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨