Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan selected src_dirs does not work in rebar3 environment #78

Open
vasu-dasari opened this issue Jan 21, 2018 · 1 comment
Open

Scan selected src_dirs does not work in rebar3 environment #78

vasu-dasari opened this issue Jan 21, 2018 · 1 comment

Comments

@vasu-dasari
Copy link
Contributor

vasu-dasari commented Jan 21, 2018

I have a project importing a lot of projects. So, I wanted sync to scan a subset of directories. So, I made my sys.conf like this:

{sync, [
    {src_dirs, {replace, [
        {"/Users/vdasari/Developer/foo/_build/default/lib/foo/src", [{outdir,"./_build/default/lib/foo/ebin"}]}
    ]}}
]}

I am using lager for logging purposes which uses lager_transform and hence compile time options for my files is quite different. rebar3 is able to figure out all the options properly. But, for sync it expects me to specify all the options for compiling my foo/src.

It would be good if sync can figure out compile-time options as well so that my sys.conf could look like this.

{sync, [
    {src_dirs, {replace, [
        {"foo/src", []}
    ]}}
]}

vasu-dasari added a commit to vasu-dasari/sync that referenced this issue Jan 21, 2018
Issue has been detailed at: rustyio#78

Found that add strategy and default strategy(no strategy) goes through discover_source_dirs() to figure out compile time options for compiling a file. Doing the same for "replace" strategy option as well.
@vasu-dasari
Copy link
Contributor Author

I have a PR #79 to address this issue. It works for me. Please let me know what you think?

vasu-dasari added a commit to vasu-dasari/sync that referenced this issue Nov 30, 2018
Issue has been detailed at: rustyio#78

Found that add strategy and default strategy(no strategy) goes through discover_source_dirs() to figure out compile time options for compiling a file. Doing the same for "replace" strategy option as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant