Close Taskana#2200 - fix the exception text for wrong classification …

…categoeries
ryzheboka · Feb 9, 2024 · 8817ae2 · 8817ae2
1 parent 652074c
commit 8817ae2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/lib/taskana-core-test/src/test/java/acceptance/TaskanaConfigurationTest.java b/lib/taskana-core-test/src/test/java/acceptance/TaskanaConfigurationTest.java
@@ -958,10 +958,12 @@ void should_ThrowInvalidArgumentEx_When_ClassificationTypesDoesNotExist() {
       assertThatThrownBy(call)
           .isInstanceOf(InvalidArgumentException.class)
           .hasMessageContaining(
-              "Parameter classificationCategoriesByType "
-                  + "(taskana.classification.categories.<KEY>) "
-                  + "contains invalid Classification Types."
-                  + " configured: [VALID] detected: [DOES_NOT_EXIST]");
+              "Parameter classificationCategoriesByType"
+                  + " (taskana.classification.categories.<KEY>) is configured incorrectly. Please"
+                  + " check whether all specified Classification Types exist. Additionally, check"
+                  + " whether the correct separator is used in the property"
+                  + " taskana.classification.types ."
+          );
     }
 
     @Test

diff --git a/lib/taskana-core/src/main/java/pro/taskana/TaskanaConfiguration.java b/lib/taskana-core/src/main/java/pro/taskana/TaskanaConfiguration.java
@@ -1055,7 +1055,6 @@ public Builder enforceServiceLevel(boolean enforceServiceLevel) {
       this.enforceServiceLevel = enforceServiceLevel;
       return this;
     }
-
     // endregion
 
     // region authentication configuration
@@ -1447,12 +1446,11 @@ private void validateConfiguration() {
       if (!new HashSet<>(classificationTypes)
           .containsAll(classificationCategoriesByType.keySet())) {
         throw new InvalidArgumentException(
-            String.format(
                 "Parameter classificationCategoriesByType (taskana.classification.categories.<KEY>)"
-                    + " contains invalid Classification Types. "
-                    + "configured: %s "
-                    + "detected: %s",
-                classificationTypes, classificationCategoriesByType.keySet()));
+                    + " is configured incorrectly. Please check whether all specified"
+                    + " Classification Types exist. Additionally, check whether the correct"
+                    + " separator is used in the property taskana.classification.types ."
+                );
       }
 
       if (!classificationCategoriesByType.keySet().containsAll(classificationTypes)) {