Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out parameters of createMerkleInstant function #16

Open
3 tasks
smol-ninja opened this issue Nov 26, 2024 · 0 comments
Open
3 tasks

Separate out parameters of createMerkleInstant function #16

smol-ninja opened this issue Nov 26, 2024 · 0 comments
Labels
effort: medium Default level of effort. priority: 2 We will do our best to deal with this. type: refactor Change that neither fixes a bug nor adds a feature. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@smol-ninja
Copy link
Member

smol-ninja commented Nov 26, 2024

As discussed in #1 (comment):

  • Add separate shared parameters struct for createMerkleLL and createMerkleLT functions. Then DRY'ify their internal logic.
  • Separate out the parameters of createMerkleInstant function and remove its dependency from the current ConstructorParams struct.
  • Remove ConstructorParams struct.

The objective is to separate out createMerkleInstant input parameters from createMerkleLL and createMerkleLT. Right now, there are a tons of parameters shared between createMerkleLL and createMerkleLT which can be DRY'ified through a common struct between them. However, due to them sharing it with createMerkleInstant, its not possible.

@smol-ninja smol-ninja added effort: medium Default level of effort. priority: 2 We will do our best to deal with this. type: refactor Change that neither fixes a bug nor adds a feature. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Default level of effort. priority: 2 We will do our best to deal with this. type: refactor Change that neither fixes a bug nor adds a feature. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Development

No branches or pull requests

1 participant