Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New external sources #74

Closed
realgooseman opened this issue Jul 6, 2024 · 5 comments
Closed

New external sources #74

realgooseman opened this issue Jul 6, 2024 · 5 comments
Labels
stale ATTRIBUTE: this issue has not had recent activity

Comments

@realgooseman
Copy link

Hi Safing team,

A month or so ago, I posted an issue on the main Portmaster GitHub repo about the need of a custom filter URL option. The answer was that it was requested a lot but not considered for now as you guys are more focused on quality over quantity. I still think giving the option to the end user to choose preset filters or import his own would be better for the overall experience and customization, even if there's a slight privacy risk as Portmaster fetches those custom URL's and possibly send PII data.

It would be great to give that option if the user choses the "Advanced Interface" in UI Mode. Add a privacy risk warning or something to inform and dissociate from risks taken with custom URL's.

In the meantime, here are the three filters I would like seen added in the sources.yml for Portmaster.
They're actively maintained, regularly updated and balanced (set & forget):

Hagezi - Multi Pro
Badmojr - 1Hosts Lite
Firebog - EasyPrivacy

Copy link

github-actions bot commented Jul 6, 2024

Greetings and welcome to our community! As this is the first issue you opened here, we wanted to share some useful infos with you:

  • 🗣️ Our community on Discord is super helpful and active. We also have an AI-enabled support bot that knows Portmaster well and can give you immediate help.
  • 📖 The Wiki answers all common questions and has many important details. If you can't find an answer there, let us know, so we can add anything that's missing.

@Raphty
Copy link
Member

Raphty commented Jul 9, 2024

Thanks for the suggestion, I guess you misunderstood, multiple times is absolutely not a lot 😅

If it were, it would be a higher priority, we see that some people are, for some reason fans of certain filter lists. As funny as this sounds to me 😂

We might add those lists, I even have been in touch with hagezi in the past clarifying if he would be ok with us using it.

The issue even with "well maintained" lists still is the same - it is a wack a mole game that never ends - Profiles are a great solution.

Adressierung some other smaller things, "possibly send PII" you will always send your IP address if you are not using SPN - that is how the internet works
Also filter lists that are not deduplicated and combined take up a lot more space and processor resources - there is a reason PiHole bakes the lists after a pull.

we would have to build something like this - which costs resources we see better spent somewhere else.

If a FOSS contribution for this feature comes around we are happy to engage, to that developer, please reach out in advance and lets talk though the specification first.

I am not saying we will never do this, but since the need seems low, with people asking 3-4 times a year... we will put resources more towards needs people currently have.

@realgooseman
Copy link
Author

Hi @Raphty,

After rechecking the answer on the original issue, you did indeed say "multiple times"...I guess I exaggerated with "a lot' 😊.
Anyways, glad the implementation is not completely unconsidered. And yes it makes sense to focus on the popular requests and issues first.

Ultimately, Portmaster remains a very useful privacy suite and kinda essential for Windows users at this point. Great job.

Copy link

This issue has been automatically marked as inactive because it has not had activity in the past two months.

If no further activity occurs, this issue will be automatically closed in one week in order to increase our focus on active topics.

@github-actions github-actions bot added the stale ATTRIBUTE: this issue has not had recent activity label Sep 11, 2024
Copy link

This issue has been automatically closed because it has not had recent activity. Thank you for your contributions.

If the issue has not been resolved, you can find more information in our Wiki or continue the conversation on our Discord.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale ATTRIBUTE: this issue has not had recent activity
Projects
None yet
Development

No branches or pull requests

2 participants