Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add other file formats to be read from #68

Open
salvadorgarciamunoz opened this issue Nov 16, 2018 · 0 comments
Open

Please add other file formats to be read from #68

salvadorgarciamunoz opened this issue Nov 16, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@salvadorgarciamunoz
Copy link
Owner

Examples:
.SPC files (SPy might help)
.MAT files (SciPy has a module for this)
Individual files per time point or one file for the whole thing

@mchlshort mchlshort self-assigned this Nov 20, 2018
@mchlshort mchlshort added the enhancement New feature or request label Dec 8, 2018
mchlshort added a commit that referenced this issue Apr 24, 2019
###All new features for first stable release now

##New Features
Can now fix the device variance in VarianceEstimator

Useful for problems where the variance estimation algorithm struggles to converge to useful variance values, putting too much variance into the instrument. Also useful if manufacturer provides variance of instrument.

##Can now read spectra directly from device CSV

#68
While it doesn't allow data to be read from other file types, it automatically transforms timestamped data into seconds and also can be used to remove negative values
New data_tools

New data tools for baseline shift, removing negative values and removing certain wavelengths to decrease problem size.

##Added ability to set bounds on certain profiles

#93
This is a really useful new feature for when we know of certain peak behaviour or know that a certain species' concentration does not go below a certain value.

##Minor additions

- can now ask to report time spent on variance estimator and parameter estimator added using ipopt for least squares into a standard example as it is actually faster and users did not have an example of its implementation.

- fixed issue in variance estimator where solver options were not passed onto suboptimizations correctly    

- spotted the use of the wrong keyword in example for variance estimation ("solver_options" instead of "solver_opts"

- spotted and fixed issue where negative D values were not being sensed by the VarianceEstimator and therefore the S matrix was still bounded to 0.

A new example runs through some of these options.

##Other fixes and extensions:

When solving the optimization problem the user can now use the ipopt warmstart option as well, such that we can use the dual variables from a previous problem for the solution of the current problem.

Lack of fit estimator works for non-absorbing species case as well now.

A new structure was implemented for the case with non-absorbing species. They are not included in the S matrix any more and are taken out of the first term in the objective of the parameter estimation problem. The user interface is still the same. The changes were just added in the backend.

New documentation still to come
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants