Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix centos toolbox container base image #146

Open
phlogistonjohn opened this issue Jul 17, 2023 · 1 comment
Open

Fix centos toolbox container base image #146

phlogistonjohn opened this issue Jul 17, 2023 · 1 comment

Comments

@phlogistonjohn
Copy link
Collaborator

phlogistonjohn commented Jul 17, 2023 •
edited
Loading

In PR #135 I added a comment to images/toolbox/Containerfile.centos:

# FIXME - this is not a real tag publicly available in the
# quay.io/samba.org/samba-client repository. This only works if you build
# the centos client locally first or acquire the image from a side channel.
# This needs to be converted to something public and/or configurable
# later.
FROM quay.io/samba.org/samba-client:centos-latest

Because the "centos-latest" tag is not universally available. It only ever exists locally on a system that first builds the centos client image. Thus the quay.io/samba.org/ part is a bit of a fib. This issue exists to discuss and do something about this

          > This raise two questions:

1. What is the appropriate tag we should use?

I don't know all I know is this will break in some circumstances. But I didn't want this PR to become sidetracked by that issue so I didn't try to fix it, just left a breadcrumb to follow up on later.

2. Should we still use `samba-client` as base image for `toolbox` or maybe use other (centos,fedora,opensuse) as base?

I think layering the images is fine, but there are some downsides to it. Let's discuss this more in a new issue or meeting, etc. :-)

Originally posted by @phlogistonjohn in #135 (comment)
@phlogistonjohn phlogistonjohn changed the title Fix centos toolbox contaien base image Fix centos toolbox container base image Jul 17, 2023
@phlogistonjohn phlogistonjohn mentioned this issue Jul 17, 2023
Merged
phlogistonjohn added a commit to phlogistonjohn/samba-container that referenced this issue Jul 18, 2023
@phlogistonjohn
github: use fqin tagging throughout the CI jobs
5d93ffa 
Use the newer Fully-Qualified-Image-Name tagging scheme in the github ci
actions yaml. This makes the naming of each image better match the core
build parameters (kind, package source, distro base (aka OS), and arch).

The major build and test targets all get an IMG_TAG env var to help
organize and make the rest of the yaml structure consistent.

One workaround we need to apply is to the toolbox builds as the
FROM line in the dockerfiles don't match FQINs nor do they match the
old scheme consistently (see samba-in-kubernetes#146). So we just do a little hack
in that section alone to get things working correctly.

Signed-off-by: John Mulligan <[email protected]>
mergify bot pushed a commit that referenced this issue Jul 19, 2023
@phlogistonjohn @mergify
github: use fqin tagging throughout the CI jobs
a6022f2 
Use the newer Fully-Qualified-Image-Name tagging scheme in the github ci
actions yaml. This makes the naming of each image better match the core
build parameters (kind, package source, distro base (aka OS), and arch).

The major build and test targets all get an IMG_TAG env var to help
organize and make the rest of the yaml structure consistent.

One workaround we need to apply is to the toolbox builds as the
FROM line in the dockerfiles don't match FQINs nor do they match the
old scheme consistently (see #146). So we just do a little hack
in that section alone to get things working correctly.

Signed-off-by: John Mulligan <[email protected]>
@obnoxxx
Copy link
Collaborator

obnoxxx commented Jul 31, 2024

@phlogistonjohn might a multi-stage build containerfile help with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obnoxxx @phlogistonjohn