You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, tried to use this library (after some problems with Apache's one), and ran into a problem with binary codec. I was looking at the source code and this place looks suspicious to me (sorry, I don't know the binary format spec, so it may be completely off the mark):
Notice how i is never modified here. You also don't seem to need the outer if, besides, req = i+1 is the same as req = 1, but since you always discard the last bit, this operation has no effect on the following req & 1 != 0 test. I think there must be some kind of a typo here, but I cannot tell where exactly.
This is Thrift description of the message I was trying to parse when I encountered this error: reading body thrift: missing required field: ResponseSysInfo.Cpu.
The text was updated successfully, but these errors were encountered:
Hi, tried to use this library (after some problems with Apache's one), and ran into a problem with binary codec. I was looking at the source code and this place looks suspicious to me (sorry, I don't know the binary format spec, so it may be completely off the mark):
Notice how
i
is never modified here. You also don't seem to need the outerif
, besides,req = i+1
is the same asreq = 1
, but since you always discard the last bit, this operation has no effect on the followingreq & 1 != 0
test. I think there must be some kind of a typo here, but I cannot tell where exactly.This is Thrift description of the message I was trying to parse when I encountered this error:
reading body thrift: missing required field: ResponseSysInfo.Cpu
.The text was updated successfully, but these errors were encountered: