use bitset in the structMeta other than uint64 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| type bits uint64 | ||
|
|
||
| // BitSet is a set of bits that can be set, cleared and queried. | ||
| type BitSet []bits |
There was a problem hiding this comment.
Shouldn't export this as it's not functionality that should be relied upon by users of the package.
|
Thanks for the patch. Just a couple of small issues if you could look into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But in the my project.The number of one struct fields is 103 , larger than 64.So I think using a bitset struct in structMeta other than uint64 may be better.