Making typedefed maps and slices passing by value. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation generates non-compilable code if typedef defined. example: type Map1 map[int32]string this would generate different access code for parameters and return values. Return values will be return by value, but argumets of functions and structure fields will be pointers. Good example of incompatible thrift is: https://github.com/osquery/osquery-python/blob/master/osquery.thrift Trying to generate and compile produce: osquery/extensions/osquery.go:191: cannot use val (type InternalExtensionList) as type *InternalExtensionList in assignment osquery/extensions/osquery.go:203: cannot use val (type InternalOptionList) as type *InternalOptionList in assignment osquery/extensions/osquery.go:287: cannot use res.Value (type *InternalExtensionList) as type InternalExtensionList in assignment osquery/extensions/osquery.go:309: cannot use res.Value (type *InternalOptionList) as type InternalOptionList in assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation generates non-compilable code
if typedef defined.
example:
type Map1 map[int32]string
this would generate different access code for parameters
and return values. Return values will be return by value,
but argumets of functions and structure fields will be pointers.
Good example of incompatible thrift is:
https://github.com/osquery/osquery-python/blob/master/osquery.thrift
Trying to generate and compile produce:
osquery/extensions/osquery.go:191: cannot use val (type
InternalExtensionList) as type *InternalExtensionList in assignment
osquery/extensions/osquery.go:203: cannot use val (type
InternalOptionList) as type *InternalOptionList in assignment
osquery/extensions/osquery.go:287: cannot use res.Value (type
*InternalExtensionList) as type InternalExtensionList in assignment
osquery/extensions/osquery.go:309: cannot use res.Value (type
*InternalOptionList) as type InternalOptionList in assignment