Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iPad: tapping on story loads different story #1876

Open
samuelclay opened this issue Jun 28, 2024 · 3 comments
Open

iPad: tapping on story loads different story #1876

samuelclay opened this issue Jun 28, 2024 · 3 comments
Assignees
@Dejal
Labels
blocked Unreproducible or need feedback critical iOS

Comments

@samuelclay
Copy link
Owner

See this video. Fresh launch, tapping on a story that isn't in the first page of stories loads the wrong story.

trim.3DB4ED78-6A91-4AC1-B4CF-435168E5DC76.MOV
@Dejal
Copy link
Collaborator

Dejal commented Jun 28, 2024

I'm unable to reproduce this; no matter how many times I launch and/or scroll to load more then select a row (with the same unread intelligence mode as you), it displays the correct story.

Does this happen regularly for you, or was this a one-off? Any clues on how to reproduce it?

@Dejal Dejal added the blocked Unreproducible or need feedback label Jul 23, 2024
@Limero Limero mentioned this issue Oct 13, 2024
Closed
samuelclay referenced this issue Nov 12, 2024
@Dejal
#1898 (Marking story as read/unread right after loading will mark dif…
1886384 
…ferent story)

- Added exta logic to check that a swipe starts and ends on the same row and story, and abandon it if not, to avoid doing the wrong thing.
- It appears that this was caused by reloading a row while loading images, so I also added logic to avoid reloading a row in the middle of a swipe.
@samuelclay
Copy link
Owner Author

Just a note, this is happening on macOS at exactly the same frequently, which is to say not particularly often, but at least once a week on daily usage.

@samuelclay
Copy link
Owner Author

It feels like a race condition between loading another page of stories and recalculating which story goes where in our "controller" array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dejal Dejal

Labels
blocked Unreproducible or need feedback critical iOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samuelclay @Dejal