Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i1020] - correct ga4 typo that prevents download tracking #6897

Merged
merged 2 commits into from
Sep 3, 2024
Merged

[i1020] - correct ga4 typo that prevents download tracking #6897

merged 2 commits into from
Sep 3, 2024

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Sep 3, 2024 •
edited
Loading

In Google Analytics we were missing the tracking for download events. This is because there was a typo in content_id.

Issue:

BEFORE

download events weren't being tracked

AFTER

Rob was able to manually trigger this event

Screenshot 2024-09-03 at 2 24 29 PM

@ShanaLMoore
[i1020] - correct ga4 typo that prevents download tracking
4cdb9de 
In Google Analytics we were missing the tracking for download events. This is because there was a typo in content_id.

Issue:
- scientist-softserv/palni-palci#1020
@ShanaLMoore ShanaLMoore mentioned this pull request Sep 3, 2024
Open
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 20m 2s ⏱️ + 4m 2s
 6 706 tests ±0   6 409 ✅ ±0  297 💤 ±0  0 ❌ ±0 
13 180 runs  ±0  12 785 ✅ ±0  395 💤 ±0  0 ❌ ±0 

Results for commit ce01a3a. ± Comparison against base commit b02cd98.

This pull request removes 274 and adds 274 tests. Note that renamed tests count towards both. 
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f85c3a571c0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fa53e858488>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f85c4817e40>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fa53e851f48>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: ff08b3dc-f1d9-4760-bfd5-fd0f347c5e73
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 4ef7fb64-eb80-4bb9-a2a4-35b58635c2d9
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: d647f373-8ac8-4b8f-827c-b2faeb013b86
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: b3d3583b-4239-4724-b780-7f5ed63aaf05
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: e1c263d2-aee5-4c33-8070-665d7ddeaeb9
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: b4fbc8fb-8810-4029-ae4a-f143dc92917c
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f2cf898f518>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fb88a41fc90>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f2cf89ec588>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fb889fae8a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: b4814fdc-8a01-490d-b7c4-9bb77440dc20
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 7ab552b6-b608-46b5-ad8a-6b252bc0d635
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 891ceb68-3136-492d-85a6-aa1b095b7b6c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 063c1ce0-b1c2-4311-be29-a05155d1feba
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 99cb84e5-0f3d-4532-9650-9abdc1c53d5f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 8fd89f33-a597-48e9-bcac-8dc7ba3239f8
…

@ShanaLMoore ShanaLMoore merged commit e1160bb into main Sep 3, 2024
22 checks passed
@ShanaLMoore ShanaLMoore deleted the i1020-ga4-followup branch September 3, 2024 21:54
@ShanaLMoore ShanaLMoore mentioned this pull request Sep 3, 2024
Merged
6 tasks
ShanaLMoore added a commit to samvera/hyku that referenced this pull request Sep 3, 2024
@ShanaLMoore
update hyrax
7c39215 
pulls in ga4 typo fix
- samvera/hyrax#6897
@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangewolf orangewolf orangewolf approved these changes

Assignees
No one assigned
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShanaLMoore @orangewolf @dlpierce