From 4cd4e947bad22f2561162afd7dca9ae9fd38384f Mon Sep 17 00:00:00 2001
From: mcorrea <manuel.correa@careerbuilder.com>
Date: Fri, 25 Sep 2015 11:35:40 -0400
Subject: [PATCH 1/2] cobetura integration

---
 zuul-simple-webapp/build.gradle | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/zuul-simple-webapp/build.gradle b/zuul-simple-webapp/build.gradle
index 7f21f769d5..318d0ff30a 100644
--- a/zuul-simple-webapp/build.gradle
+++ b/zuul-simple-webapp/build.gradle
@@ -1,5 +1,10 @@
+plugins {
+    id 'net.saliman.cobertura' version '2.2.7'
+}
 apply plugin: 'war'
 apply plugin: 'jetty'
+apply plugin: 'cobertura'
+apply plugin: 'groovy'
 
 
 dependencies {
@@ -30,3 +35,8 @@ jettyRun.contextPath = '/'
 jettyRun.doFirst {
     System.setProperty("zuul.filter.root", "src/main/groovy/filters")
 }
+
+cobertura {
+    coverageSourceDirs = [sourceSets.main.groovy.srcDirs, sourceSets.main.java.srcDirs]
+    coverageFormats = ['xml', 'html']
+}
\ No newline at end of file

From 10d0f0a6133ead306881744a23d94a5b17df59ab Mon Sep 17 00:00:00 2001
From: mcorrea <manuel.correa@careerbuilder.com>
Date: Fri, 25 Sep 2015 12:46:40 -0400
Subject: [PATCH 2/2] tomcat, checkstyle, codenarc, and findbugs

---
 zuul-simple-webapp/build.gradle               |  42 +++-
 .../config/checkstyle/checkstyle.xml          | 188 ++++++++++++++++++
 .../config/codenarc/rules.groovy              |   8 +
 3 files changed, 236 insertions(+), 2 deletions(-)
 create mode 100644 zuul-simple-webapp/config/checkstyle/checkstyle.xml
 create mode 100644 zuul-simple-webapp/config/codenarc/rules.groovy

diff --git a/zuul-simple-webapp/build.gradle b/zuul-simple-webapp/build.gradle
index 318d0ff30a..479268254b 100644
--- a/zuul-simple-webapp/build.gradle
+++ b/zuul-simple-webapp/build.gradle
@@ -1,17 +1,26 @@
 plugins {
     id 'net.saliman.cobertura' version '2.2.7'
+    id "com.bmuschko.tomcat" version "2.2.2"
+    id 'codenarc'
+    id 'findbugs'
+    id 'checkstyle'
 }
 apply plugin: 'war'
 apply plugin: 'jetty'
 apply plugin: 'cobertura'
 apply plugin: 'groovy'
 
-
 dependencies {
     compile project(":zuul-core")
 
     compile 'org.apache.httpcomponents:httpclient:4.5'
     providedCompile 'javax.servlet:servlet-api:2.5'
+
+    def tomcatVersion = '8.0.23'
+    tomcat "org.apache.tomcat.embed:tomcat-embed-core:${tomcatVersion}",
+            "org.apache.tomcat.embed:tomcat-embed-logging-juli:${tomcatVersion}",
+            "org.apache.tomcat.embed:tomcat-embed-jasper:${tomcatVersion}"
+
 }
 
 eclipse {
@@ -39,4 +48,33 @@ jettyRun.doFirst {
 cobertura {
     coverageSourceDirs = [sourceSets.main.groovy.srcDirs, sourceSets.main.java.srcDirs]
     coverageFormats = ['xml', 'html']
-}
\ No newline at end of file
+}
+
+checkstyle {
+    toolVersion = '6.7'
+    ignoreFailures = true
+    showViolations = false
+    sourceSets = [sourceSets.main]
+    reportsDir = rootProject.file('zuul-simple-webapp/build/reports/checkstyle')
+}
+
+codenarc {
+    configFile = rootProject.file('zuul-simple-webapp/config/codenarc/rules.groovy')
+    ignoreFailures = true
+    sourceSets = [sourceSets.main]
+    reportFormat = 'xml'
+}
+
+findbugs {
+    effort = 'min'
+    ignoreFailures = true
+    sourceSets = [sourceSets.main]
+}
+
+tomcat {
+    contextPath = '/'
+}
+
+[tomcatRun, tomcatRunWar]*.doFirst {
+    System.setProperty("zuul.filter.root", "src/main/groovy/filters")
+}
diff --git a/zuul-simple-webapp/config/checkstyle/checkstyle.xml b/zuul-simple-webapp/config/checkstyle/checkstyle.xml
new file mode 100644
index 0000000000..2d17204330
--- /dev/null
+++ b/zuul-simple-webapp/config/checkstyle/checkstyle.xml
@@ -0,0 +1,188 @@
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
+          "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
+
+<!--
+
+    Checkstyle configuration that checks the Google coding conventions from:
+    
+    -  Google Java Style
+       https://google-styleguide.googlecode.com/svn-history/r130/trunk/javaguide.html
+       
+    Checkstyle is very configurable. Be sure to read the documentation at
+    http://checkstyle.sf.net (or in your downloaded distribution).
+
+    Most Checks are configurable, be sure to consult the documentation.
+
+    To completely disable a check, just comment it out or delete it from the file.
+
+    Authors: Max Vetrenko, Ruslan Diachenko, Roman Ivanov.
+    
+ -->
+ 
+<module name = "Checker">
+    <property name="charset" value="UTF-8"/>
+    
+    <property name="severity" value="warning"/>
+
+    <property name="fileExtensions" value="java, properties, xml"/>
+    <!-- Checks for whitespace                               -->
+    <!-- See http://checkstyle.sf.net/config_whitespace.html -->
+        <module name="FileTabCharacter">
+            <property name="eachLine" value="true"/>
+        </module>
+    
+    <module name="TreeWalker">
+        <module name="OuterTypeFilename"/>
+        <module name="IllegalTokenText">
+            <property name="tokens" value="STRING_LITERAL, CHAR_LITERAL"/>
+            <property name="format" value="\\u00(08|09|0(a|A)|0(c|C)|0(d|D)|22|27|5(C|c))|\\(0(10|11|12|14|15|42|47)|134)"/>
+            <property name="message" value="Avoid using corresponding octal or Unicode escape."/>
+        </module>
+        <module name="AvoidEscapedUnicodeCharacters">
+            <property name="allowEscapesForControlCharacters" value="true"/>
+            <property name="allowByTailComment" value="true"/>
+            <property name="allowNonPrintableEscapes" value="true"/>
+        </module>
+        <module name="LineLength">
+            <property name="max" value="100"/>
+            <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
+        </module>
+        <module name="AvoidStarImport"/>
+        <module name="OneTopLevelClass"/>
+        <module name="NoLineWrap"/>
+        <module name="EmptyBlock">
+            <property name="option" value="TEXT"/>
+            <property name="tokens" value="LITERAL_TRY, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>
+        </module>
+        <module name="NeedBraces"/>
+        <module name="LeftCurly">
+            <property name="maxLineLength" value="100"/>
+        </module>
+        <module name="RightCurly"/>
+        <module name="RightCurly">
+            <property name="option" value="alone"/>
+            <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
+        </module>
+        <module name="WhitespaceAround">
+            <property name="allowEmptyConstructors" value="true"/>
+            <property name="allowEmptyMethods" value="true"/>
+            <property name="allowEmptyTypes" value="true"/>
+            <property name="allowEmptyLoops" value="true"/>
+            <message key="ws.notFollowed"
+             value="WhitespaceAround: ''{0}'' is not followed by whitespace. Empty blocks may only be represented as '{}' when not part of a multi-block statement (4.1.3)"/>
+             <message key="ws.notPreceded"
+             value="WhitespaceAround: ''{0}'' is not preceded with whitespace."/>
+        </module>
+        <module name="OneStatementPerLine"/>
+        <module name="MultipleVariableDeclarations"/>
+        <module name="ArrayTypeStyle"/>
+        <module name="MissingSwitchDefault"/>
+        <module name="FallThrough"/>
+        <module name="UpperEll"/>
+        <module name="ModifierOrder"/>
+        <module name="EmptyLineSeparator">
+            <property name="allowNoEmptyLineBetweenFields" value="true"/>
+        </module>
+        <module name="SeparatorWrap">
+            <property name="tokens" value="DOT"/>
+            <property name="option" value="nl"/>
+        </module>
+        <module name="SeparatorWrap">
+            <property name="tokens" value="COMMA"/>
+            <property name="option" value="EOL"/>
+        </module>
+        <module name="PackageName">
+            <property name="format" value="^[a-z]+(\.[a-z][a-z0-9]*)*$"/>
+            <message key="name.invalidPattern"
+             value="Package name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="TypeName">
+            <message key="name.invalidPattern"
+             value="Type name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="MemberName">
+            <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
+            <message key="name.invalidPattern"
+             value="Member name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="ParameterName">
+            <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
+            <message key="name.invalidPattern"
+             value="Parameter name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="LocalVariableName">
+            <property name="tokens" value="VARIABLE_DEF"/>
+            <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
+            <property name="allowOneCharVarInForLoop" value="true"/>
+            <message key="name.invalidPattern"
+             value="Local variable name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="ClassTypeParameterName">
+            <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
+            <message key="name.invalidPattern"
+             value="Class type name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="MethodTypeParameterName">
+            <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
+            <message key="name.invalidPattern"
+             value="Method type name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="NoFinalizer"/>
+        <module name="GenericWhitespace">
+            <message key="ws.followed"
+             value="GenericWhitespace ''{0}'' is followed by whitespace."/>
+             <message key="ws.preceded"
+             value="GenericWhitespace ''{0}'' is preceded with whitespace."/>
+             <message key="ws.illegalFollow"
+             value="GenericWhitespace ''{0}'' should followed by whitespace."/>
+             <message key="ws.notPreceded"
+             value="GenericWhitespace ''{0}'' is not preceded with whitespace."/>
+        </module>
+        <module name="Indentation">
+            <property name="basicOffset" value="4"/>
+            <property name="braceAdjustment" value="0"/>
+            <property name="caseIndent" value="2"/>
+            <property name="throwsIndent" value="4"/>
+            <property name="lineWrappingIndentation" value="4"/>
+            <property name="arrayInitIndent" value="2"/>
+        </module>
+        <module name="AbbreviationAsWordInName">
+            <property name="ignoreFinal" value="false"/>
+            <property name="allowedAbbreviationLength" value="5"/>
+        </module>
+        <module name="OverloadMethodsDeclarationOrder"/>
+        <module name="VariableDeclarationUsageDistance"/>
+        <module name="CustomImportOrder">
+            <property name="specialImportsRegExp" value="com.google"/>
+            <property name="sortImportsInGroupAlphabetically" value="true"/>
+            <property name="customImportOrderRules" value="STATIC###SPECIAL_IMPORTS###THIRD_PARTY_PACKAGE###STANDARD_JAVA_PACKAGE"/>
+        </module>
+        <module name="MethodParamPad"/>
+        <module name="OperatorWrap">
+            <property name="option" value="NL"/>
+            <property name="tokens" value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "/>
+        </module>
+        <module name="AnnotationLocation">
+            <property name="tokens" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF"/>
+        </module>
+        <module name="AnnotationLocation">
+            <property name="tokens" value="VARIABLE_DEF"/>
+            <property name="allowSamelineMultipleAnnotations" value="true"/>
+        </module>
+        <module name="NonEmptyAtclauseDescription"/>
+        <module name="AtclauseOrder">
+            <property name="tagOrder" value="@param, @return, @throws, @deprecated"/>
+            <property name="target" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
+        </module>
+        <module name="MethodName">
+            <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9_]*$"/>
+            <message key="name.invalidPattern"
+             value="Method name ''{0}'' must match pattern ''{1}''."/>
+        </module>
+        <module name="EmptyCatchBlock">
+            <property name="exceptionVariableName" value="expected"/>
+        </module>
+    </module>
+</module>
diff --git a/zuul-simple-webapp/config/codenarc/rules.groovy b/zuul-simple-webapp/config/codenarc/rules.groovy
new file mode 100644
index 0000000000..80feba2611
--- /dev/null
+++ b/zuul-simple-webapp/config/codenarc/rules.groovy
@@ -0,0 +1,8 @@
+ruleset {
+    ruleset 'rulesets/basic.xml'
+    ruleset 'rulesets/braces.xml'
+    ruleset('rulesets/dry.xml') {
+        DuplicateNumberLiteral(enabled:false)
+    }
+    ruleset 'rulesets/groovyism.xml'
+}