Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_hana_install: hdblcm configfile parameter 'verify_signature' is set incorrectly #899

Open
berndfinger opened this issue Nov 27, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@berndfinger
Copy link
Member

The string after sap_hana_install_ in the role variable sap_hana_install_verify_signature (verify_signature) is an hdblcm configfile parameter and therefore processed by the role for creating the hdblcm configfile. This causes this configfile parameter to be set to True or False instead of y or n.

The role does what we expect anyway (tested on SPS05, rev. 59.15 and SPS80, rev. 80):

  • If the role variable sap_hana_install_verify_signature is set to the default of false, the hdblcm command line parameter --verify_signature is not added by the role, and the configfile parameter verify_signature, which is set to False, is interpreted by hdblcm as 'No'.

  • If the role variable sap_hana_install_verify_signature is set to the alternative setting of true, the hdblcm command line parameter --verify_signature is added by the role, and the configfile parameter verify_signature, which is set to True, is ignored by hdblcm.

Such a behavior can be avoided by using another prefix (e.g. sap_hana_install_cfg_) for those role variables which are used for converting the hdblcm configfile template into a Jinja2 template, in task:

- name: SAP HANA Pre Install - Create a Jinja2 template from the hdblcm configfile template

With this mechanism, the "role native" variables can be separated from those role variables which are used for directly setting the hdblcm configfile parameters.

@berndfinger berndfinger self-assigned this Nov 27, 2024
@berndfinger berndfinger added the enhancement New feature or request label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant