Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_region is mandatory for AWS cluster but not validated #41

Closed
mpagot opened this issue Jan 29, 2024 · 1 comment
Closed

aws_region is mandatory for AWS cluster but not validated #41

mpagot opened this issue Jan 29, 2024 · 1 comment

Comments

@mpagot
Copy link
Contributor

mpagot commented Jan 29, 2024

I'm creating a deployment with playbook using cluster role from this repo: SUSE/qe-sap-deployment#202

I noticed that, if I forgot to provide aws_region, the role fails as the variable is needed by task Ensure config file has cluster block.

That's fine but:

  • it is not properly documented in the readme, in the Required variables for AWS section of

    community.sles-for-sap/roles/cluster/README.md

    Line 144 in 00c5182

    ### Required Variables for AWS
  • it is not validated by task Ensure that AWS specific variables are supplied
@mpagot mpagot mentioned this issue Jan 29, 2024
Merged
@marcelmamula
Copy link
Contributor

PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpagot @marcelmamula