Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install VPN if PSK/Username/Password is not changed by user #11

Open
VarunAgw opened this issue Jan 30, 2016 · 3 comments
Open

Don't install VPN if PSK/Username/Password is not changed by user #11

VarunAgw opened this issue Jan 30, 2016 · 3 comments

Comments

@VarunAgw
Copy link

I recently re-installed it on an old server. I forgot to change username/password and just ran the script absentmindedly, hoping it will not change the old username/password. I couldn't test it earlier and today I found my server was open to anyone for last 2 days

So my suggestion is to require change in username/password before allowing anyone to run it or best just ask all these details at runtime using read function .

@sarfata
Copy link
Owner

sarfata commented Jan 30, 2016

Thanks for the suggestion. Could you make those changes and send a pull-request?

@VarunAgw
Copy link
Author

Which one do you prefer?

@sarfata
Copy link
Owner

sarfata commented Feb 1, 2016

Not sure. I guess the person implementing this gets to decide ;)

My first intuition would be to just check that the user has changed the default information. This way you can keep a copy of the project locally, change the user/pass and re-use it whenever you need it. But again, I have no strong preference for one or the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants