Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks.register_model function incorrectly allows users to import Python models to SAS Viya 4 #137

Open
smlindauer opened this issue Nov 10, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@smlindauer
Copy link
Collaborator

Describe the issue
As seen in issue #136, when attempting to import a Python model with register_model() to SAS Viya 4, the normal process for SAS Viya 3.5 is used which produces a DS2 wrapped version of the Python model. This approach is not valid in SAS Viya 4, as SAS Model Manager creates the DS2 wrapper when publishing or scoring the model.

To Reproduce
Follow any of the example scripts that use register_model() to import a Python model.

Expected behavior
python-sasctl should be checking against the version of SAS Viya that register_model is attempting to import to. If a Python model is detected and SAS Viya 4 is detected, an error should be produced stating that this function cannot import models into SAS Viya 4 successfully.

Version
1.7.3

@smlindauer smlindauer added the bug Something isn't working label Nov 10, 2022
@smlindauer smlindauer self-assigned this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant