Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: sbb-datepicker enhancements #3256

Open
3 tasks done
stefan-schubert-sbb opened this issue Nov 27, 2024 · 0 comments
Open
3 tasks done

[Feature request]: sbb-datepicker enhancements #3256

stefan-schubert-sbb opened this issue Nov 27, 2024 · 0 comments

Comments

@stefan-schubert-sbb
Copy link

Preflight Checklist

Request type

Request for enhancement of a component

It affects the following packages

Components

Functionality

It would be nice to have the following pain points to be fixed for sbb-datepicker:

  1. include the input node in the sbb-datepicker component
    • one node is simpler to handle for attaching external libraries to have form validation
    • alternatively: provide the whole interface at sbb-datepicker, such as: name, disabled, min, max, onchange, oninput, valueAsDate, value
  2. use milliseconds or date objects for min, max
    • why not using milli seconds instead of seconds?
    • if min, max can be set at sbb-datepicker, it would be nice to use date objects
  3. data-sbb-invalid at input or maybe in future at sbb-datepicker should contain the error reason: invalidInput, tooEarlyDate, tooLateDate, filteredOutDate
    • optional: sbb-datepicker could provide a error status property to ready the error reason directly
  4. onvalidationchange should also be fired on switching from one error to another error
    • the error reason should also be given as event payload like in the data attribute describe above

I'm looking forward to the discussion.

Link to design proposal file

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant