You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With [lib]Combine, a CMake file called [lib]Combine-static-config.cmake gets generated. Such a CMake file cannot be found on a case-sensitive system (since that kind of filename should be all lower case). Instead, a CMake file called [lib]combine-static-config.cmake should be generated, hence the suggestion to rename the library to [lib]combine, not least so that it's consistent with libSBML, for instance.
The text was updated successfully, but these errors were encountered:
The problem that i see, is with this change, all packages that ever used libCombine will have to change. So far they would have had a fallback statement using the CONFIGS flag on case sensitive filesystems. But with the PR the number of variables to test would have to be doubled (checking for [lib][c|C]ombine), to test. Here is how other projects were importing in the past:
With
[lib]Combine
, a CMake file called[lib]Combine-static-config.cmake
gets generated. Such a CMake file cannot be found on a case-sensitive system (since that kind of filename should be all lower case). Instead, a CMake file called[lib]combine-static-config.cmake
should be generated, hence the suggestion to rename the library to[lib]combine
, not least so that it's consistent with libSBML, for instance.The text was updated successfully, but these errors were encountered: