Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary duplication of SWIG command? #10

Open
mattagape opened this issue Jun 2, 2021 · 0 comments
Open

Unnecessary duplication of SWIG command? #10

mattagape opened this issue Jun 2, 2021 · 0 comments

Comments

@mattagape
Copy link
Contributor

In liblx/src/bindings/python/CMakeLists.txt, and presumably in the equivalent in libSBML, there are two invocations of the swig executable, like:

  COMMAND "${SWIG_EXECUTABLE}"
    ARGS  -I${CMAKE_CURRENT_SOURCE_DIR}/../swig/
        -I${CMAKE_CURRENT_SOURCE_DIR} 
        -I${CMAKE_CURRENT_BINARY_DIR} 
        ...

One of these invocations has the -DGENERATING_DOCS option.

Do we need to invoke swig twice like this?

This does not appear to be a problem with the other bindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant