Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JGit to version 7 #264

Open
caenrique opened this issue Oct 17, 2024 · 2 comments
Open

Update JGit to version 7 #264

caenrique opened this issue Oct 17, 2024 · 2 comments

Comments

@caenrique
Copy link

Hi, would it be possible to update jgit to version 7?

it supports working with git worktrees, which the current version used here doesn't
https://projects.eclipse.org/projects/technology.jgit/releases/7.0.0

@mkurz
Copy link
Member

mkurz commented Oct 17, 2024

Please see my comment:

jgit 7 requires Java 17, and I don't expect that sbt-git at the moment still supports Java 8... Next step will be dropping Java 8 first, so sbt-git can upgrade to jgit 6:

I expect that until sbt-git drops Java 11 and can therefore upgrade to jgit 7 many years will pass...
Meanwhile, you can just upgrade to jgit 7 yourself, if your projects only requires Java 17+. Look how we in Play are planning to do just that:

Be aware however, if #243 gets merged as-is currently, you probaby want to set

ThisBuild / com.github.sbt.git.SbtGit.GitKeys.useConsoleForROGit := false

in your build.sbt. That's because right now #243 does not check if you have jgit 7 on the classpath and will still fallback to the command line git command even if you have jgit 7 on the classpath.
I came up with an idea on how to resolve this in this comment, so if this can be figured out, setting useConsoleForROGit := false will not be even necessary.
So I suggest you to follow #243 for updates.

@caenrique
Copy link
Author

Thank you, that's really useful. I'll read up on those links :)

It really is a bit sad that things are like this for something as ubiquitous as git support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants