Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthetic methods are not being accounted correctly. #294

Open
BillyBQ opened this issue Dec 18, 2023 · 0 comments
Open

Synthetic methods are not being accounted correctly. #294

BillyBQ opened this issue Dec 18, 2023 · 0 comments

Comments

@BillyBQ
Copy link

BillyBQ commented Dec 18, 2023

Hi sbt-jacoco Development Team,

The following two issues were discovered recently while investigating the coverage report of our product.

  1. On 04/19/2019 there was a commit "Upgrade to jacoco 0.8.2 (Upgrade to jacoco 0.8.2 #119)" that was later released with tag v3.2.0. In this commit FilteringClassAnalyzer stopped updating field coverages, which causes com.github.sbt.jacoco.filter.ScalaSyntheticMethod#isSyntheticMethod not being called and synthetic method as a result not ignored from the coverage calculation.

  2. productElementName and productElementNames (from scala.Product) should be added to the list of method names in com.github.sbt.jacoco.filter.ScalaSyntheticMethod#isCaseInstanceMethod so that they can be ignored from coverage calculation as synthetic methods.

Please kindly look into the issues and release a fix if possible.

Thanks,

Billy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant