Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Images redraw when no trims are set. #242

Closed
2 tasks done
sca075 opened this issue Aug 16, 2024 · 2 comments · Fixed by #252
Closed
2 tasks done

Tracking: Images redraw when no trims are set. #242

sca075 opened this issue Aug 16, 2024 · 2 comments · Fixed by #252
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@sca075
Copy link
Owner

sca075 commented Aug 16, 2024

Checklist

  • I have updated the integration to the latest version available
  • I have checked if the problem is already reported

The problem

When resetting the trims with reset_trim at current is implemented that if the vacuum isn't "docked" the trims should be re-calculated at each frame. While testing the new released 2024.08.1 I noticed that (on V1 vacuums but probably also with other) the Camera render the robot and path but not the floor. Reload of the Camera correctly update the image.

What version of an integration has described problem?

2024.08.1

What was the last working version of an integration?

2024.06.4

What vacuum model do you have problems with?

Roborock.V1

Please firmware installed on your Vacuum.

not relevant.

What type of platform you use?

ARM (Raspberry Pi, Odroid, etc.) > 4GB

What version of Home Assistant do you use?

2024.8.1

What type of installation are you running?

Home Assistant OS

Logs or Errors shown in the HA snapshots (please enable the Debug Mode) text will be auto formatted to code.

No errors occurs but from the logs the image base layer looks never draw till the camera reload.

Function, that in your opinion is creating the issue.

Image Aspect Ratio

Additional information

Will be working on this trying to confirm the root cause and eventually fix it. This issue is for tracing reason created.

@sca075 sca075 added bug Something isn't working enhancement New feature or request labels Aug 16, 2024
@sca075 sca075 self-assigned this Aug 16, 2024
@sca075 sca075 added this to the 2024.10.0 milestone Sep 12, 2024
@sca075 sca075 linked a pull request Sep 16, 2024 that will close this issue
@sca075
Copy link
Owner Author

sca075 commented Sep 16, 2024

Found cause of the issue, the fix should be released with one of the beta of 2024.10.0

@sca075 sca075 pinned this issue Sep 16, 2024
@sca075
Copy link
Owner Author

sca075 commented Sep 17, 2024

Thanks to @hayvan96 in https://community.home-assistant.io/t/valetudo-vacuums-map-camera-for-home-assistant/600182/141?u=gsca075 it looks that by calling the camera reset_trims service once now the issue with the image update is fixed :)
To automatically detect when it is the case to reset the trims I'm going to implement an event "vacuum.start", so that the camera will reset the trims automatically.

@sca075 sca075 unpinned this issue Nov 16, 2024
@sca075 sca075 pinned this issue Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant