Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements and Refactorings for FossilDbIterators #8211

Open
3 tasks
fm3 opened this issue Nov 18, 2024 · 0 comments
Open
3 tasks

Performance improvements and Refactorings for FossilDbIterators #8211

fm3 opened this issue Nov 18, 2024 · 0 comments

Comments

@fm3
Copy link
Member

fm3 commented Nov 18, 2024

VersionedFossilDbIterator and its dependents are used when multiple keys of fossildb-saved data are processed sequentially. Some ideas how to improve them:

  • Cleanup: Generic Reversion-Aware Iterator? Build on top of VersionedFossilDbIterator? Could replace VersionedAgglomerateToGraphIterator, VersionedSegmentToAgglomerateChunkIterator and VolumeTracingBucketProvider?
  • For proofreading iterators, save perf by skipping fetching content when only version is needed in iterator (different from volume, because here we don’t need to update the segment index)
    • that might need new fossildb api (ListKeysWithVersions)
  • Make the iterators async? Use async fossildb api?

Should be tackled after #7839 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant