Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(triggers): public and private containers triggers example #51

Merged
merged 13 commits into from
Oct 20, 2023
Merged

feat(triggers): public and private containers triggers example #51

merged 13 commits into from
Oct 20, 2023

Conversation

Shillaker
Copy link
Contributor

@Shillaker Shillaker commented Oct 19, 2023 •
edited
Loading

Summary

Checklist

  • I have reviewed this myself.
  • I have attached a README to my example. You can use this template as reference.
  • I have updated the project README to link my example.

Details

@norbjd norbjd requested a review from cyclimse October 20, 2023 12:40
@norbjd norbjd marked this pull request as ready for review October 20, 2023 12:40
@norbjd
Copy link
Contributor

norbjd commented Oct 20, 2023 •
edited
Loading

Hello 👋

Passing this PR ready after the last changes; I've rerun the example multiple times following the README.md, it works fine on my side. Please try to reproduce on your side too just in case I've missed something :)

Thanks!

@Shillaker Shillaker removed their assignment Oct 20, 2023
cyclimse
cyclimse approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@cyclimse cyclimse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some very minor nitpicks

Will we update it with the release of the next terraform version?

containers/terraform-triggers/tests/send_messages.py Outdated Show resolved Hide resolved
containers/terraform-triggers/docker/python/requirements.txt Outdated Show resolved Hide resolved
containers/terraform-triggers/mnq_sqs.tf Outdated Show resolved Hide resolved
@norbjd
Copy link
Contributor

norbjd commented Oct 20, 2023

LGTM, some very minor nitpicks

Will we update it with the release of the next terraform version?

@cyclimse Yes, I think we can even start right before the next release (we'll just need to rebuild terraform provider).

@norbjd norbjd merged commit a680b21 into main Oct 20, 2023
7 checks passed
@norbjd norbjd deleted the container-trigger-example branch October 20, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norbjd norbjd norbjd left review comments

@cyclimse cyclimse cyclimse approved these changes

Assignees

@norbjd norbjd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shillaker @norbjd @cyclimse