Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(triggers): update functions examples for new MnQ API #52

Merged
merged 4 commits into from
Oct 24, 2023
Merged

chore(triggers): update functions examples for new MnQ API #52

merged 4 commits into from
Oct 24, 2023

Conversation

Shillaker
Copy link
Contributor

Summary

  • Update MnQ-related resources to use new Terraform resources
  • Tidy up docs

Checklist

  • I have reviewed this myself.
  • I have attached a README to my example. You can use this template as reference.
  • I have updated the project README to link my example.

@Shillaker Shillaker self-assigned this Oct 24, 2023
@Shillaker Shillaker requested a review from norbjd October 24, 2023 09:42
@Shillaker Shillaker changed the title chore(triggers): update examples for new MnQ API chore(triggers): update functions examples for new MnQ API Oct 24, 2023
norbjd
norbjd approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@norbjd norbjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and it works :)

(I've added 2 commits for docs 1eb16f2, 4ccb878 to clarify docs)

@Shillaker Shillaker merged commit 1be72ae into main Oct 24, 2023
7 checks passed
@Shillaker Shillaker deleted the mnq-updates branch November 10, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norbjd norbjd norbjd approved these changes

Assignees

@Shillaker Shillaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shillaker @norbjd