Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default oplogPopulatorChangeStreamLimit to 10 #2589

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

francoisferrand
Copy link
Contributor

Should not trigger an alert by default.

Issue: BB-627

Should not trigger an alert by default.

Issue: BB-627
@bert-e
Copy link
Contributor

bert-e commented Nov 8, 2024

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.49%. Comparing base (6131ba0) to head (258eed4).
Report is 2 commits behind head on development/8.6.

Additional details and impacted files

Impacted file tree graph

Components Coverage Δ
Bucket Notification 66.66% <ø> (ø)
Core Library 73.98% <ø> (ø)
Ingestion 69.24% <ø> (ø)
Lifecycle 75.00% <ø> (ø)
Oplog Populator 82.95% <ø> (ø)
Replication 57.42% <ø> (ø)
Bucket Scanner 85.60% <ø> (ø)
@@               Coverage Diff                @@
##           development/8.6    #2589   +/-   ##
================================================
  Coverage            69.49%   69.49%           
================================================
  Files                  194      194           
  Lines                12864    12864           
================================================
  Hits                  8940     8940           
  Misses                3914     3914           
  Partials                10       10           
Flag Coverage Δ
api:retry 9.66% <ø> (ø)
api:routes 9.56% <ø> (ø)
bucket-scanner 85.60% <ø> (ø)
ingestion 12.52% <ø> (ø)
lib 7.55% <ø> (ø)
lifecycle 19.43% <ø> (ø)
notification 0.88% <ø> (ø)
replication 18.97% <ø> (ø)
unit 43.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bert-e
Copy link
Contributor

bert-e commented Nov 12, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@scality scality deleted a comment from bert-e Nov 12, 2024
@francoisferrand
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 12, 2024

Integration data created

I have created the integration data for the additional destination branches.

  • this pull request will merge bugfix/BB-627 into
    development/8.6
  • w/8.7/bugfix/BB-627 will be merged into development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 12, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.6

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

Please check the status of the associated issue BB-627.

Goodbye francoisferrand.

The following options are set: approve

@bert-e bert-e merged commit 258eed4 into development/8.6 Nov 12, 2024
9 checks passed
@bert-e bert-e deleted the bugfix/BB-627 branch November 12, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants