Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Angular 1.4 compatibility #18

Open
karser opened this issue Jun 20, 2015 · 2 comments
Open

Angular 1.4 compatibility #18

karser opened this issue Jun 20, 2015 · 2 comments
Assignees
@czerwingithub

Comments

@karser
Copy link

karser commented Jun 20, 2015

Parameters of function $new were changed. Usage scalyr with angular 1.4 produces errors.

$new: function(isolate, parent)

https://github.com/angular/bower-angular/blob/master/angular.js#L13834
karser added a commit to karser/angular that referenced this issue Jun 20, 2015
@karser
scalyr#18 Angular 1.4 compatibility
771748b
@karser
Copy link
Author

karser commented Jun 20, 2015

Please accept the pull request

@czerwingithub czerwingithub self-assigned this Jun 22, 2015
@czerwingithub
Copy link
Contributor

Can you issue your change as a pull request against the main repository? Right now that change list you reference is just against your forked repository so I don't have an easy way to accept/merge it from the UI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@czerwingithub czerwingithub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karser @czerwingithub