Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature requests based on recent usage #46

Open
jjhart opened this issue Dec 17, 2020 · 0 comments
Open

Feature requests based on recent usage #46

jjhart opened this issue Dec 17, 2020 · 0 comments

Comments

@jjhart
Copy link

jjhart commented Dec 17, 2020

  • Short-circuit out of sendEvents if there is nothing to send; sending empty ingestion batches to the Scalyr backend is confusing/misleading

  • Support wildcards in the matcher rules config; support a "match all" conceit too so we don’t even need to specify a particular key (let alone static value, as current)

  • Add rate-limited logging if the EventMapper only ever returns null, something like this (here):

int nonNullCount = records.stream()
      .map(eventMapper::createEvent)
      .filter(Objects::nonNull)
      .peek(event -> {
        if (eventBuffer.estimatedSerializedBytes() + event.estimatedSerializedBytes() >= batchSendSizeBytes) {
          sendEvents();
        }
        eventBuffer.addEvent(event);
      })
      .count();

if (nonNullCount == 0) {
  log.rateLimitedWarn(..);
  return;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant