Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PDFs are not re-extracted after they're updated #39

Open
scambier opened this issue Sep 18, 2023 · 2 comments
Open

[BUG] PDFs are not re-extracted after they're updated #39

scambier opened this issue Sep 18, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@scambier
Copy link
Owner

Problem description:

scambier/obsidian-omnisearch#291 (reply in thread)

Your environment:

  • Plugin version:
  • Obsidian version:
  • Operating system:
  • Number of images/PDFs in your vault (approx.):
  • Other plugins that may be related to the issue:
@scambier scambier added the bug Something isn't working label Sep 18, 2023
@scambier
Copy link
Owner Author

  • A PDF is only extracted on demand (e.g. when Omnisearch wants to index it, or when using the contextual menu)
  • Once Omnisearch has built its cache, it won't re-extract (or hit the cache of) a PDF unless it appears in a result

A solution would be to add a "automatically extract" opt-in setting in Text Extractor, that would keep the cache up-to-date

@demig00d
Copy link
Contributor

demig00d commented Jan 17, 2024

@scambier, what do you think about adding the modification time to the cache file name?

While it may result in a larger number of cache files, it seems like a simpler solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants