Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] RTLR support #6

Open
YMHJERUSALEM opened this issue Jan 21, 2023 · 4 comments
Open

[BUG] RTLR support #6

YMHJERUSALEM opened this issue Jan 21, 2023 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@YMHJERUSALEM
Copy link

HI there; first time here, so I hope I am doing it right...
I am trying to work with OMNISEARCH, but it doesn't support RTL IMNGs and PDFs.
If so- please consider including it in the following features.
If not- what am I missing here?
Thank you very much!
@scambier scambier transferred this issue from scambier/obsidian-omnisearch Jan 22, 2023
@scambier scambier self-assigned this Jan 22, 2023
scambier added a commit that referenced this issue Jan 22, 2023
@scambier
Fixed not using the settings languages #1 #6
718d894
@scambier
Copy link
Owner

I've published an update to Text Extractor that should fix this for images. Regarding PDFs, if you have some test files to send me, I'll gladly take them :)

@scambier scambier added enhancement New feature or request waiting for feedback The maintainer is waiting for additional information/confirmation labels Jan 23, 2023
@YMHJERUSALEM
Copy link
Author

WOW, thank you so much,
though I still need help with something, it doesn't work also after re-downloading both textextractor both omnysearch; maybe I need to do something different...
here is an example of an RTL PDF.
Man, I really much appreciate your comment, and try to help!!

לורבורגוים טעמי המצוות.pdf

@scambier scambier removed the waiting for feedback The maintainer is waiting for additional information/confirmation label Jan 26, 2023
@scambier
Copy link
Owner

scambier commented Jan 26, 2023 •
edited
Loading

It looks like text is correctly extracted from this PDF, and that it's correctly displayed as RTL into Obsidian?

image
(The selection highlight goes from right to left)

@YMHJERUSALEM
Copy link
Author

Actually no, it's turning the text around.
And at least from my tryings, its not working with the png\jpg...
Thanks again

@scambier scambier removed their assignment Mar 2, 2023
@scambier scambier added the help wanted Extra attention is needed label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scambier @YMHJERUSALEM