Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose private members of ArcballCameraControl as protected #591

Open
kephale opened this issue Jul 22, 2023 · 0 comments
Open

Expose private members of ArcballCameraControl as protected #591

kephale opened this issue Jul 22, 2023 · 0 comments

Comments

@kephale
Copy link
Member

kephale commented Jul 22, 2023

We need to modify these variables in subclasses, so they should be protected instead of private.

scenery/src/main/kotlin/graphics/scenery/controls/behaviours/ArcballCameraControl.kt

Lines 33 to 35 in 6b2aa7d

private val logger by lazyLogger()
private var lastX = w / 2
private var lastY = h / 2

kephale added a commit to scenerygraphics/sciview that referenced this issue Jul 22, 2023
@kephale
Invert y-axis motion
17ae4c3 
This could be simplified after
scenerygraphics/scenery#591 is addressed
@kephale kephale mentioned this issue Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kephale