-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy to Fiji #577
Merged
Merged
Deploy to Fiji #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrueden
force-pushed
the
deploy-to-fiji
branch
3 times, most recently
from
April 18, 2024 10:37
ac51ee3
to
29b2382
Compare
* The task now stores Fiji.app into the build folder by default. * We eschew the ImageJ launcher now in favor of calling the java executable associated with the Gradle process's JVM. The arguments used are designed to mirror as closely as possible what the ImageJ launcher feeds to libjvm when launching Fiji, except that machine-specific arguments are left commented out.
We will add more tasks to this file shortly.
* fijiDownload downloads fiji-nojre.zip on demand. * fijiUnpack unpacks it into build/fiji/Fiji.app. * fijiUpdate updates the build/fiji/Fiji.app to the latest. * fijiPopulate copies sciview+deps into build/fiji/Fiji.app. * fijiUpload uploads Fiji.app's sciview+deps to the sciview update site. * fijiClean deletes build/fiji/Fiji.app. * fijiDistClean deletes fiji-nojre.zip and build/fiji/Fiji.app. The logic of fijiPopulate was already there as populateFiji, but was renamed for consistency of a common prefix. Co-authored-by: Ulrik Guenther <[email protected]>
The almighty Gradle handles all of these functions for us now. Run `./gradlew tasks` and check the ones beginning with `fiji`.
skalarproduktraum
force-pushed
the
deploy-to-fiji
branch
from
April 18, 2024 10:58
29b2382
to
134e13e
Compare
ctrueden
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's awesome. Big step forward for easier Fiji deployment. Thanks, me!
No, but seriously - this was actually great and fun work together 🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new Gradle tasks to help with deployment to our Fiji update site.