Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 backup postgres Dockerfile specifies ENV variable of S3_PATH, but image actually uses S3_PREFIX #61

Open
danimbrogno opened this issue Jan 25, 2017 · 1 comment

Comments

@danimbrogno
Copy link

I think this might be a small typo and is related to #59, In the dockerfile it sets a default for the env variable:

ENV S3_PATH 'backup',

but in backup.sh, the env variable S3_PREFIX is used instead:

cat dump.sql.gz | aws s3 cp - s3://$S3_BUCKET/$S3_PREFIX/$(date +"%Y-%m-%dT%H:%M:%SZ").sql.gz || exit 2

I think the Dockerfile needs to be updated. If this is accurate I can submit a pull request.

@philstrong
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants