PDF.js not rendering when it should #880
Assignees
Labels
Comments
laritakr
added a commit
that referenced
this issue
Nov 13, 2024
# Story Refs: - #880 - #881 In the case of a split work, :pdf? needs to be included in the methods checked on a presenter. In the case of a work that isn't split, Valkyrie has changed the term we use to check for a `.pdf` suffix. It appears that we do not fill in the label term. If characterization fails and we fall back to looking for a pdf, we needed to look in the right location. # Expected Behavior Before Changes When PDF.js is selected via flipper and a work has been split, it sometimes just shows a thumbnail. When PDF.js is selected via flipper and work is not split, it sometimes just shows a thumbnail. # Expected Behavior After Changes In new (valkyrie) resources, resources converted from Fedora, and works still in Fedora: - When PDF.js is selected via flipper and a work has been split, it shows the UV - When PDF.js is selected via flipper and a work is not split, it shows the PDF in PDF.js # Screenshots / Video <details> <summary>Both of these originally showed thumbnails only</summary>   </details> # Notes
|
I'm seeing some unsplit works (uploaded before the cutover) are failing to show the PDF in the PDF.js viewer, but the thumbnail is displaying in the UV. So weird! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
example:
https://adl.b2.adventistdigitallibrary.org/concern/published_works/20218025_ellen_white_and_her_work
Acceptance Criteria
Screenshots or Video
Testing Instructions
To be filled out by dev
Notes
The text was updated successfully, but these errors were encountered: