Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UV not rendering when it should #881

Open
ShanaLMoore opened this issue Nov 8, 2024 · 4 comments
Open

UV not rendering when it should #881

ShanaLMoore opened this issue Nov 8, 2024 · 4 comments
Assignees

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Nov 8, 2024

Summary

example: https://adl.b2.adventistdigitallibrary.org/concern/published_works/israel_vol__03__no__27_1918_the_remnant_of_israel_april_1918?locale=en

image

Acceptance Criteria

  • [ ]

Screenshots or Video

Testing Instructions

To be filled out by dev

Notes

@KatharineV
Copy link
Collaborator

laritakr added a commit that referenced this issue Nov 13, 2024
# Story

Refs:
- #880 
- #881 

In the case of a split work, :pdf? needs to be included in the methods
checked on a presenter.
In the case of a work that isn't split, Valkyrie has changed the term we
use to check for a `.pdf` suffix. It appears that we do not fill in the
label term. If characterization fails and we fall back to looking for a
pdf, we needed to look in the right location.

# Expected Behavior Before Changes

When PDF.js is selected via flipper and a work has been split, it
sometimes just shows a thumbnail.
When PDF.js is selected via flipper and work is not split, it sometimes
just shows a thumbnail.

# Expected Behavior After Changes

In new (valkyrie) resources, resources converted from Fedora, and works
still in Fedora:

- When PDF.js is selected via flipper and a work has been split, it
shows the UV
- When PDF.js is selected via flipper and a work is not split, it shows
the PDF in PDF.js

# Screenshots / Video

<details>
<summary>Both of these originally showed thumbnails only</summary>

![Screenshot 2024-11-13 at 2 51
37 PM](https://github.com/user-attachments/assets/0dbc51c1-a365-4b1a-a79d-3ce33d9d718d)


![Screenshot 2024-11-13 at 2 47
01 PM](https://github.com/user-attachments/assets/43050ab0-1783-4136-bd53-321cff20efc9)

</details>

# Notes
@jillpe jillpe moved this to Deploy to Staging in Adventist Knapsack Nov 14, 2024
@jillpe jillpe moved this from Deploy to Staging to SoftServ QA in Adventist Knapsack Nov 14, 2024
@ShanaLMoore
Copy link
Contributor Author

Should the UV be displaying here?

@KatharineV
Copy link
Collaborator

I know that LaRita pushed some fixes yesterday, so I'm dropping a note about what I see today with the UV.

Some works that split in the past are now displaying in the UV.
Example: https://adl.b2.adventistdigitallibrary.org/concern/generic_works/oak_dykes_3_3_002_dr_dykes_lecture_ntoes

Some split works are displaying a black box in the UV.
Example 1: https://adl.b2.adventistdigitallibrary.org/concern/published_works/oak_dykes_5_3_002_missionary_volunteer_songs_for_senior_and_junior_missio
Example 2: https://adl.b2.adventistdigitallibrary.org/concern/generic_works/oak_dykes_1_17_a_tribute_to_dr_dykes

I found at least two works that never split but the UV is showing the thumbnail rather than PDF.js showing the PDF.
Example 1: https://adl.b2.adventistdigitallibrary.org/concern/published_works/20122816_the_laws_of_life_november_0_1863
Example 2: https://adl.b2.adventistdigitallibrary.org/concern/published_works/20123224_calendar_keene_industrial_school_july_1_1894

Most works that never split are still stuck in thumbnail, showing no viewer (either PDF.js or UV).
Example 1: https://adl.b2.adventistdigitallibrary.org/concern/published_works/22251069_history_of_the_seventh_day_adventist_young_people_s_work
Example 2: https://adl.b2.adventistdigitallibrary.org/concern/published_works/22250825_quagmire_jungle_desert_or_what_the_pros_and_cons_of_televisio

Some TIFFs are showing in the UV (Example: https://adl.b2.adventistdigitallibrary.org/concern/generic_works/oak_dykes_3_18_file_minneola_dixon_s_dr_dykes_file) but most TIFFs and all JPEGs that I've seen so far are displaying as thumbnails only. TIFF: https://adl.b2.adventistdigitallibrary.org/concern/images/p008400__andrews_university_president_leroy_richard_hammill_in_his_office?locale=en
JPEG: https://adl.b2.adventistdigitallibrary.org/concern/images/rml_ms009_140_china_division_workers_and_missionary_volunteer_leaders

I tried to import a few new images into production to see how the UV works with new images in the repo, but Bulkrax failed with an error I've never seen before. I'll create a ticket for that and will test new image works after a fix is in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: SoftServ QA
Development

No branches or pull requests

3 participants