-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UV not rendering when it should #881
Labels
Comments
Confirmed today that the UV is showing JPEG and TIFF files. It is rendering VERY SLOWLY. But it does show the image file eventually. |
laritakr
added a commit
that referenced
this issue
Nov 13, 2024
# Story Refs: - #880 - #881 In the case of a split work, :pdf? needs to be included in the methods checked on a presenter. In the case of a work that isn't split, Valkyrie has changed the term we use to check for a `.pdf` suffix. It appears that we do not fill in the label term. If characterization fails and we fall back to looking for a pdf, we needed to look in the right location. # Expected Behavior Before Changes When PDF.js is selected via flipper and a work has been split, it sometimes just shows a thumbnail. When PDF.js is selected via flipper and work is not split, it sometimes just shows a thumbnail. # Expected Behavior After Changes In new (valkyrie) resources, resources converted from Fedora, and works still in Fedora: - When PDF.js is selected via flipper and a work has been split, it shows the UV - When PDF.js is selected via flipper and a work is not split, it shows the PDF in PDF.js # Screenshots / Video <details> <summary>Both of these originally showed thumbnails only</summary> ![Screenshot 2024-11-13 at 2 51 37 PM](https://github.com/user-attachments/assets/0dbc51c1-a365-4b1a-a79d-3ce33d9d718d) ![Screenshot 2024-11-13 at 2 47 01 PM](https://github.com/user-attachments/assets/43050ab0-1783-4136-bd53-321cff20efc9) </details> # Notes
Should the UV be displaying here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
example: https://adl.b2.adventistdigitallibrary.org/concern/published_works/israel_vol__03__no__27_1918_the_remnant_of_israel_april_1918?locale=en
Acceptance Criteria
Screenshots or Video
Testing Instructions
To be filled out by dev
Notes
The text was updated successfully, but these errors were encountered: