Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interim fix to stop IIIF print running for PDFs with many pages #541

Open
grahamjevon opened this issue May 7, 2024 · 2 comments
Open

Comments

@grahamjevon
Copy link
Collaborator

grahamjevon commented May 7, 2024

Problem

If a work has many child works, the parent work page may not render. Any attempt to open the work will time out. Here is an example.

This is a problem for any work with a PDF with several hundred pages (e.g. a book) because the IIIF print process automatically creates a child work for each page. Thus the simple act of uploading a PDF file with hundreds of pages will render the work inaccessible and there is nothing the user can do to prevent this (other than not uploading the PDF file or manually deleting hundreds of child works, which is prohibitively time consuming).

Solution

A comprehensive fix that resolves the page rendering issue with all the child works remaining in situ requires investigation.

In the meantime, a quick fix is to create a script that decides whether or not the IIIF print process should run based on the number of pages in the PDF. For example:

  • If < 150 pages, run IIIF print process
  • Else do not run IIIF print process.

The implication of not running the IIIF print process is that the PDF will not be accessible via the UV. It will only be available for download. But this is preferable to the page not rendering at all.

@grahamjevon grahamjevon converted this from a draft issue May 7, 2024
@cziaarm cziaarm moved this from In Development to Client QA in britishlibrary May 15, 2024
@cziaarm
Copy link
Collaborator

cziaarm commented May 15, 2024

Limit currently set to 100

https://bl.bl-staging.notch8.cloud/concern/articles/767ab3ef-c4f4-491f-9d57-4444f7a88778?locale=en

This PDF has 552 pages... IiifPRint stays well clear.

@grahamjevon
Copy link
Collaborator Author

This works as expected when using both the UI and BX. PDF files uploaded with < 100 pages successfully go through the IIIF print process. PDF files >= 100 pages successfully skip the IIIF print process.

@grahamjevon grahamjevon moved this from Client QA to Deploy to Production in britishlibrary May 20, 2024
@cziaarm cziaarm moved this from Deploy to Production to Client Verification in britishlibrary May 28, 2024
@grahamjevon grahamjevon moved this from Client Verification to Done in britishlibrary May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants