Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchNotification Bug #121

Closed
1 task
ShanaLMoore opened this issue Aug 15, 2024 · 2 comments
Closed
1 task

BatchNotification Bug #121

ShanaLMoore opened this issue Aug 15, 2024 · 2 comments
Assignees
Labels
bug something isn't working High Priority Pitt

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Aug 15, 2024

Summary

Rob identified a bug within the BatchEmailNotication work we did, because we put the last_emailed_at property on the User table.

His suggestion is to create and write to a join table instead.

notes for steps to resolve it:

new migration to remove last_emailed_at from user table
rails g model UserBatchEmail referencs:user last_emailed_at:datetime
User#last_emailed_at
  self.user_batch_email.find_or_create.last_emailed_at
User#last_emailed_at=(value)
  self.user_batch_email.find_or_create.update(last_emailed_at:  value)

related:

Acceptance Criteria

  • The code has been updated to utilize a join table instead of the User table, to query/update last_emailed_at.
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Aug 26, 2024

QA RESULTS: ⚠️ PENDING

This appears to be working. Tested with THIS TENANT,

The email matches the details of the dashboard.

However, I am clicking around a bunch in another tenant. (demo tenant) It'll take about a day for the events to get tracked with GA4. Those stats and email should be different. right now it's kind of odd that the stats are the same.

DEMO profile

Image

EMAIL

Image

ADMIN DASHBOARD

Image

@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Aug 29, 2024

QA will be completed under scientist-softserv/palni-palci#1020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working High Priority Pitt
Projects
None yet
Development

No branches or pull requests

2 participants