Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF: Autoencoder FINTA ConvNext #246

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

AntoineTheb
Copy link
Collaborator

@AntoineTheb AntoineTheb commented Oct 1, 2024

Description

Add a new autoencoder model inspired by ConvNext: https://arxiv.org/abs/2201.03545

Testing data and script

Ask Arnaud for data

Have you

  • Added a description of the content of this PR above
  • Followed proper commit message formatting
  • Added data and a script to test this PR
  • Made sure that PEP8 issues are resolved
  • Tested the code yourself right before pushing
  • Added unit tests to test the code you implemented

People this PR concerns

@pep8speaks
Copy link

pep8speaks commented Oct 1, 2024

Hello @AntoineTheb, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-10-03 21:03:57 UTC

@AntoineTheb AntoineTheb changed the title [WIP] Autoencoder FINTA ConvNext NF: Autoencoder FINTA ConvNext Oct 3, 2024
Copy link
Collaborator

@levje levje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

scripts_python/ae_autoencode_streamlines.py Outdated Show resolved Hide resolved
scripts_python/ae_autoencode_streamlines.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Either we wait for latent space viz before merging or Jeremi or I could add it after merging.

@@ -0,0 +1,136 @@
#!/usr/bin/env python
# -*- coding: utf-8 -*-
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to ae_autoencode_tractogram.py

"as a data per point (color)")

# Additional arg for projects
p.add_argument('--model', type=str, choices=['finta', 'convnext'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put it as a mandatory argument.

@AntoineTheb
Copy link
Collaborator Author

@arnaudbore don't wait for me I'll be busy with MICCAI then vacations so I'll rebase and adjust once @levje's pr is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants