Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anapaya review #38

Closed
nicorusti opened this issue Jul 23, 2024 · 3 comments
Closed

Anapaya review #38

nicorusti opened this issue Jul 23, 2024 · 3 comments
Assignees
Labels
Milestone

Comments

@nicorusti
Copy link
Member

nicorusti commented Jul 23, 2024

Points to be reviewed:

Links:

  • Diff -04 (09.23) / current version
@nicorusti nicorusti added this to the -07 milestone Jul 26, 2024
@oncilla
Copy link

oncilla commented Oct 7, 2024

Note that this is a sensitive TRC update, as the
certificate related to the compromised private key MUST be
replaced with an entirely new certificate (and not just changed).

This is not exactly true. If only the public key changes, and all other parameters are the same, It is a regular update AFAIK.

@oncilla
Copy link

oncilla commented Oct 7, 2024

A trust reset is only required in the case the number of
compromised keys at the same time is greater or equal than the
TRC's quorum (see Section 3.1.2.2.7).

and a invalid update has been produced and distributed in the network. I think if the compromise is noticed early enough and an Update is issued and distributed in the network, then there is nothing an attacker can do anymore. Nodes in the SCION network store all the TRCs they have seen, and history cannot be rewriten.

@nicorusti
Copy link
Member Author

nicorusti commented Oct 9, 2024

Right, I had a look at the two changes and I agree with you. I added your changes in #46 , let me know if this is clear enough.

Are you done with reviewing the draft?

We also have #28 , I'm looking for some ASN.1 experts to have a look :) Would you mind having a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants