Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve the SIG doc with the text from the ietf drafts #4641

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jiceatscion
Copy link
Contributor

Fixes #4640

@jiceatscion
Copy link
Contributor Author

This change is Reviewable

Copy link
Contributor

@nicorusti nicorusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @jiceatscion and @oncilla)


doc/sig.rst line 80 at r3 (raw file):
How about adding back this sentence?

The Session ID and Stream ID are chosen by the sender but the tuple MUST be unique within a session.


doc/sig.rst line 25 at r3 (raw file):

====================

IP packets are encapsulated into SIG frames, which are sent as SCION/UDP datagrams.

IN the draft we had these few lines that explained reasons to use SIG framing instead of other protocols. How about we leave them somewhere?

Code snippet:

This protocol is designed to:

- provide independence from the underlying SCION path MTU which can increase and decrease over time.
- provide fast detection of packet loss and subsequent recovery of decapsulation for packets that weren't lost.
- support for multiple streams within a framing session such that independent packet sequences be tunneled in parallel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: update SIG description
2 participants